Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Segment Replication] Use deterministic mechanism to have concurrent invocation of segment replication #8937

Merged
merged 2 commits into from
Jul 28, 2023

Conversation

dreamer-89
Copy link
Member

@dreamer-89 dreamer-89 commented Jul 27, 2023

Description

Fixes SegmentReplicationTargetServiceTests.testShardAlreadyReplicating flaky test by ensuring first round of segment replication is not completed before invoking next round.

Related Issues

Resolves #8928

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…invocation of segment replication

Signed-off-by: Suraj Singh <[email protected]>
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@dreamer-89
Copy link
Member Author

dreamer-89 commented Jul 27, 2023

Gradle Check (Jenkins) Run Completed with:

Screenshot 2023-07-27 at 4 23 26 PM

NRTReplicationReaderManagerTests.testUpdateSegmentsWhileRefreshing -> #8941
SegmentReplicationUsingRemoteStoreIT.testDropPrimaryDuringReplication -> #8059

Signed-off-by: Suraj Singh <[email protected]>
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      1 org.opensearch.search.suggest.CompletionSuggestSearchIT.testSkipDuplicates

@codecov
Copy link

codecov bot commented Jul 28, 2023

Codecov Report

Merging #8937 (21f3036) into main (91bc891) will decrease coverage by 0.10%.
Report is 4 commits behind head on main.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #8937      +/-   ##
============================================
- Coverage     71.05%   70.95%   -0.10%     
- Complexity    57198    57215      +17     
============================================
  Files          4758     4758              
  Lines        269863   269863              
  Branches      39484    39484              
============================================
- Hits         191755   191491     -264     
- Misses        61982    62283     +301     
+ Partials      16126    16089      -37     

see 469 files with indirect coverage changes

@dreamer-89 dreamer-89 merged commit 8edc1dd into opensearch-project:main Jul 28, 2023
@dreamer-89 dreamer-89 added the backport 2.x Backport to 2.x branch label Jul 28, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jul 28, 2023
…invocation of segment replication (#8937)

* [Segment Replication] Use deterministic mechanism to have concurrent invocation of segment replication

Signed-off-by: Suraj Singh <[email protected]>

* Clean up

Signed-off-by: Suraj Singh <[email protected]>

---------

Signed-off-by: Suraj Singh <[email protected]>
(cherry picked from commit 8edc1dd)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
mch2 pushed a commit that referenced this pull request Jul 28, 2023
baba-devv pushed a commit to baba-devv/OpenSearch that referenced this pull request Jul 28, 2023
…invocation of segment replication (opensearch-project#8937)

* [Segment Replication] Use deterministic mechanism to have concurrent invocation of segment replication

Signed-off-by: Suraj Singh <[email protected]>

* Clean up

Signed-off-by: Suraj Singh <[email protected]>

---------

Signed-off-by: Suraj Singh <[email protected]>
baba-devv pushed a commit to baba-devv/OpenSearch that referenced this pull request Jul 29, 2023
…invocation of segment replication (opensearch-project#8937)

* [Segment Replication] Use deterministic mechanism to have concurrent invocation of segment replication

Signed-off-by: Suraj Singh <[email protected]>

* Clean up

Signed-off-by: Suraj Singh <[email protected]>

---------

Signed-off-by: Suraj Singh <[email protected]>
kaushalmahi12 pushed a commit to kaushalmahi12/OpenSearch that referenced this pull request Sep 12, 2023
…invocation of segment replication (opensearch-project#8937)

* [Segment Replication] Use deterministic mechanism to have concurrent invocation of segment replication

Signed-off-by: Suraj Singh <[email protected]>

* Clean up

Signed-off-by: Suraj Singh <[email protected]>

---------

Signed-off-by: Suraj Singh <[email protected]>
Signed-off-by: Kaushal Kumar <[email protected]>
brusic pushed a commit to brusic/OpenSearch that referenced this pull request Sep 25, 2023
…invocation of segment replication (opensearch-project#8937)

* [Segment Replication] Use deterministic mechanism to have concurrent invocation of segment replication

Signed-off-by: Suraj Singh <[email protected]>

* Clean up

Signed-off-by: Suraj Singh <[email protected]>

---------

Signed-off-by: Suraj Singh <[email protected]>
Signed-off-by: Ivan Brusic <[email protected]>
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
…invocation of segment replication (opensearch-project#8937)

* [Segment Replication] Use deterministic mechanism to have concurrent invocation of segment replication

Signed-off-by: Suraj Singh <[email protected]>

* Clean up

Signed-off-by: Suraj Singh <[email protected]>

---------

Signed-off-by: Suraj Singh <[email protected]>
Signed-off-by: Shivansh Arora <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch skip-changelog
Projects
None yet
2 participants