-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add completion count in SearchBackpressure nodeStats API #8701
Conversation
Gradle Check (Jenkins) Run Completed with:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shall we also include a metric suggesting whether the node is under duress or not? It will be useful for investigation.
IsNodeUnderDuress
can be added in the SearchBackpressureStats
pojo.
server/src/main/java/org/opensearch/search/backpressure/stats/SearchTaskStats.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/opensearch/search/backpressure/stats/SearchTaskStats.java
Outdated
Show resolved
Hide resolved
Gradle Check (Jenkins) Run Completed with:
|
server/src/main/java/org/opensearch/search/backpressure/stats/SearchBackpressureStats.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/opensearch/search/backpressure/stats/SearchShardTaskStats.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/opensearch/search/backpressure/stats/SearchShardTaskStats.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/opensearch/search/backpressure/stats/SearchShardTaskStats.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/opensearch/search/backpressure/stats/SearchShardTaskStats.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/opensearch/search/backpressure/stats/SearchTaskStats.java
Outdated
Show resolved
Hide resolved
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
…project#9719) --------- Signed-off-by: bansvaru <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]>
* Fix default tracer falky test Signed-off-by: Gagan Juneja <[email protected]> * Empty-Commit Signed-off-by: Gagan Juneja <[email protected]> * Address review comment Signed-off-by: Gagan Juneja <[email protected]> * Empty-Commit Signed-off-by: Gagan Juneja <[email protected]> * Address review comment Signed-off-by: Gagan Juneja <[email protected]> --------- Signed-off-by: Gagan Juneja <[email protected]> Co-authored-by: Gagan Juneja <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]>
…ct#9840) Signed-off-by: Ticheng Lin <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]>
…oreFormat (opensearch-project#9908) Signed-off-by: bansvaru <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]>
…pensearch-project#9727) * Improve performance of rounding dates in date_histogram aggregation Signed-off-by: Ketan Verma <[email protected]> * Minor refactoring changes Signed-off-by: Ketan Verma <[email protected]> --------- Signed-off-by: Ketan Verma <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]>
…peTestCase annotation (opensearch-project#9916) Signed-off-by: Neetika Singhal <[email protected]> Signed-off-by: Andriy Redko <[email protected]> Co-authored-by: Andriy Redko <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]>
…nt Replication (opensearch-project#9585) * support realtime TermVector and MultiTermVector requests with segment replication. Signed-off-by: Rishikesh1159 <[email protected]> * Fix TermVector requests with segrep. Signed-off-by: Rishikesh1159 <[email protected]> * Refacotring. Signed-off-by: Rishikesh1159 <[email protected]> * Address comments on PR. Signed-off-by: Rishikesh1159 <[email protected]> --------- Signed-off-by: Rishikesh1159 <[email protected]> Signed-off-by: Rishikesh Pasham <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]>
…ject#9415) * Add Instrumentation Signed-off-by: Gagan Juneja <[email protected]> * update changelog Signed-off-by: Gagan Juneja <[email protected]> * clear the context Signed-off-by: Gagan Juneja <[email protected]> * Add Instrumentation Signed-off-by: Gagan Juneja <[email protected]> * Fix test cases Signed-off-by: Gagan Juneja <[email protected]> * Empty-Commit Signed-off-by: Gagan Juneja <[email protected]> * Add Instrumentation Signed-off-by: Gagan Juneja <[email protected]> * Add Instrumentation Signed-off-by: Gagan Juneja <[email protected]> * Remove internal transport action check Signed-off-by: Gagan Juneja <[email protected]> * Changes Signed-off-by: Gagan Juneja <[email protected]> * Refactor code Signed-off-by: Gagan Juneja <[email protected]> * Address review comment Signed-off-by: Gagan Juneja <[email protected]> * Fix failing test cases Signed-off-by: Gagan Juneja <[email protected]> * Address review comment Signed-off-by: Gagan Juneja <[email protected]> * Fix failing test cases Signed-off-by: Gagan Juneja <[email protected]> * Fix failing test cases Signed-off-by: Gagan Juneja <[email protected]> * Fix failing test cases Signed-off-by: Gagan Juneja <[email protected]> * Fix failing test cases Signed-off-by: Gagan Juneja <[email protected]> * Empty-Commit Signed-off-by: Gagan Juneja <[email protected]> * Fix failing test cases Signed-off-by: Gagan Juneja <[email protected]> * Fix java doc Signed-off-by: Gagan Juneja <[email protected]> * Address review comment Signed-off-by: Gagan Juneja <[email protected]> * Address review comment Signed-off-by: Gagan Juneja <[email protected]> * Empty-Commit Signed-off-by: Gagan Juneja <[email protected]> * Address review comment Signed-off-by: Gagan Juneja <[email protected]> * Address review comment Signed-off-by: Gagan Juneja <[email protected]> * Address merge conflicts Signed-off-by: Gagan Juneja <[email protected]> * Address merge conflicts Signed-off-by: Gagan Juneja <[email protected]> * Empty-Commit Signed-off-by: Gagan Juneja <[email protected]> * Empty-Commit Signed-off-by: Gagan Juneja <[email protected]> * Enable NumberOfTraceIDsEqualToRequests test Signed-off-by: Gagan Juneja <[email protected]> * Fix java doc Signed-off-by: Gagan Juneja <[email protected]> * Fix java doc Signed-off-by: Gagan Juneja <[email protected]> * Empty-Commit Signed-off-by: Gagan Juneja <[email protected]> * Address review comment Signed-off-by: Gagan Juneja <[email protected]> * Address review comment Signed-off-by: Gagan Juneja <[email protected]> * Fix test case Signed-off-by: Gagan Juneja <[email protected]> * Remove instrumentation from TransportService Signed-off-by: Gagan Juneja <[email protected]> --------- Signed-off-by: Gagan Juneja <[email protected]> Signed-off-by: Gagan Juneja <[email protected]> Co-authored-by: Gagan Juneja <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]>
This plugin has been moved to its own [repository][1]. [1]: https://github.com/opensearch-project/custom-codecs Signed-off-by: Andrew Ross <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]>
…dle simulation (opensearch-project#9915) Signed-off-by: Kunal Kotwani <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]>
* Clear CHANGELOG for released 2.x changes Signed-off-by: Kunal Kotwani <[email protected]> * Add release notes for 2.10 Signed-off-by: Kunal Kotwani <[email protected]> --------- Signed-off-by: Kunal Kotwani <[email protected]>
…ject#9956) Fix is pending in opensearch-project#7771, but that PR may take some time to land in main so muting for the time being. Signed-off-by: Andrew Ross <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]>
Instead of appending a new comment every time check compatibility runs, this will instead update a single comment with the latest results. The history of previous runs is retained in the comment as GitHub allows you to view the edited revisions of any comment. This matches the behavior of the codecov workflow and should substantially reduce noise in PRs. Relates opensearch-project#9699 Signed-off-by: Andrew Ross <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]>
* fixing javadoc of org.opensearch.cli.Terminal Signed-off-by: Laurent Laborde <[email protected]> * fixing javadoc of org.opensearch.cli.ExitCodes Signed-off-by: Laurent Laborde <[email protected]> * fixing javadoc Signed-off-by: Laurent Laborde <[email protected]> * fixing a mishap in formatting rule Signed-off-by: Laurent Laborde <[email protected]> --------- Signed-off-by: Laurent Laborde <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]>
…ject#9575) * Bump peter-evans/create-or-update-comment from 2 to 3 Bumps [peter-evans/create-or-update-comment](https://github.com/peter-evans/create-or-update-comment) from 2 to 3. - [Release notes](https://github.com/peter-evans/create-or-update-comment/releases) - [Commits](peter-evans/create-or-update-comment@v2...v3) --- updated-dependencies: - dependency-name: peter-evans/create-or-update-comment dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> * Update changelog Signed-off-by: dependabot[bot] <[email protected]> --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com> Signed-off-by: Kaushal Kumar <[email protected]>
* Bump actions/checkout from 2 to 4 Bumps [actions/checkout](https://github.com/actions/checkout) from 2 to 4. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v2...v4) --- updated-dependencies: - dependency-name: actions/checkout dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> * Update changelog Signed-off-by: dependabot[bot] <[email protected]> --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com> Signed-off-by: Kaushal Kumar <[email protected]>
…earch-project#9973) Signed-off-by: Andriy Redko <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]>
Update changelog. Signed-off-by: Austin Lee <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]>
Signed-off-by: Andriy Redko <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]>
…ct#9965) Signed-off-by: Sooraj Sinha <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]>
c1b607c
to
9d497bf
Compare
Signed-off-by: Kaushal Kumar <[email protected]>
Gradle Check (Jenkins) Run Completed with:
|
ec40d92
to
1f56190
Compare
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Please rebase--this says 331 commits are involved with this change. Thank you |
Closing this PR in favor of #10028 due to DCO validation failure in a past commit. |
Description
With this change the nodeStats API will also return the completionCount of search tasks at shard and coordinator level.
new sample response for an API call like
curl "localhost:9200/_nodes/stats/search_backpressure?pretty"
will look like the followingRelated Issues
Resolves #8698
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.