[Remote Store] Simplify lock manager interface

[sachinpkale]

Description

• Currently, we have following for remote store lock manager (omitting details not in context of lock manager):

public interface RemoteStoreLockManager;

public class RemoteStoreMetadataLockManager implements RemoteStoreLockManager {
        private final RemoteDirectory lockDirectory;
}

public interface RemoteStoreCommitLevelLockManager;

public class RemoteSegmentStoreDirectory implements RemoteStoreCommitLevelLockManager {
        private final RemoteDirectory remoteDataDirectory;
        private final RemoteDirectory remoteMetadataDirectory;
        private final RemoteStoreLockManager mdLockManager;
}

• This PR tries to simplify this structure in the following:

public interface RemoteStoreLockManager;

public class RemoteSegmentStoreDirectory implements RemoteStoreLockManager {
        private final RemoteDirectory remoteDataDirectory;
        private final RemoteDirectory remoteMetadataDirectory;
        private final RemoteDirectory lockDirectory;
}

Check List

• New functionality includes testing.
  • All tests pass
• New functionality has been documented.
  • New functionality has javadoc added
• Commits are signed per the DCO using --signoff
• Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: FAILURE ❌
• URL: https://build.ci.opensearch.org/job/gradle-check/18938/
• CommitID: ad6f8f9
  Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
  Is the failure a flaky test unrelated to your change?

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: FAILURE ❌
• URL: https://build.ci.opensearch.org/job/gradle-check/18939/
• CommitID: e908731
  Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
  Is the failure a flaky test unrelated to your change?

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: ❌
• URL: https://build.ci.opensearch.org/job/gradle-check/18942/
• CommitID: edf29b1
  Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
  Is the failure a flaky test unrelated to your change?

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: ❌
• URL: https://build.ci.opensearch.org/job/gradle-check/18941/
• CommitID: 21f3449
  Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
  Is the failure a flaky test unrelated to your change?

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: FAILURE ❌
• URL: https://build.ci.opensearch.org/job/gradle-check/18945/
• CommitID: fe7cc08
  Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
  Is the failure a flaky test unrelated to your change?

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: FAILURE ❌
• URL: https://build.ci.opensearch.org/job/gradle-check/18984/
• CommitID: c4999b1
  Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
  Is the failure a flaky test unrelated to your change?

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: FAILURE ❌
• URL: https://build.ci.opensearch.org/job/gradle-check/18988/
• CommitID: 0a64a71
  Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
  Is the failure a flaky test unrelated to your change?

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: FAILURE ❌
• URL: https://build.ci.opensearch.org/job/gradle-check/19007/
• CommitID: c45249e
  Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
  Is the failure a flaky test unrelated to your change?

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: UNSTABLE ❕
• TEST FAILURES:

      1 org.opensearch.snapshots.RestoreSnapshotIT.testRestoreRemoteStoreIndicesWithoutRemoteTranslog
      1 org.opensearch.remotestore.SegmentReplicationUsingRemoteStoreIT.testNodeDropWithOngoingReplication

• URL: https://build.ci.opensearch.org/job/gradle-check/19009/
• CommitID: 2a07d71
  Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

[codecov]

Codecov Report

Attention: 19 lines in your changes are missing coverage. Please review.

Comparison is base (1f3a7a8) 70.91% compared to head (f68d52b) 71.00%.
Report is 847 commits behind head on main.

❗ Current head f68d52b differs from pull request most recent head 03b351d. Consider uploading reports for the commit 03b351d to get more accurate results

Files	Patch %	Lines
...earch/index/store/RemoteSegmentStoreDirectory.java	53.33%	10 Missing and 4 partials ⚠️
...in/java/org/opensearch/index/shard/IndexShard.java	50.00%	3 Missing ⚠️
...ensearch/index/store/lockmanager/FileLockInfo.java	0.00%	1 Missing and 1 partial ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               main    #8399      +/-   ##
============================================
+ Coverage     70.91%   71.00%   +0.09%     
- Complexity    56926    56976      +50     
============================================
  Files          4758     4756       -2     
  Lines        269186   269176      -10     
  Branches      39399    39410      +11     
============================================
+ Hits         190896   191139     +243     
+ Misses        62179    61890     -289     
- Partials      16111    16147      +36     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: UNSTABLE ❕
• TEST FAILURES:

      1 org.opensearch.remotestore.SegmentReplicationUsingRemoteStoreIT.testNodeDropWithOngoingReplication
      1 org.opensearch.remotestore.SegmentReplicationUsingRemoteStoreIT.testDropPrimaryDuringReplication

• URL: https://build.ci.opensearch.org/job/gradle-check/19029/
• CommitID: f68d52b
  Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

[sachinpkale]

Adding more tests to address CodeCov failure.

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: FAILURE ❌
• URL: https://build.ci.opensearch.org/job/gradle-check/19081/
• CommitID: 03b351d
  Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
  Is the failure a flaky test unrelated to your change?

[opensearch-trigger-bot]

This PR is stalled because it has been open for 30 days with no activity. Remove stalled label or comment or this will be closed in 7 days.

[opensearch-trigger-bot]

This PR was closed because it has been stalled for 7 days with no activity.

[kotwanikunal]

Apologies. This PR was auto closed without reaching a resolution from the maintainers.
Re-opening to move it forward.
Thanks for your contributions to OpenSearch!

[github-actions]

Compatibility status:

Checks if related components are compatible with change 03b351d

Incompatible components

Skipped components

Compatible components

Compatible components: []

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: FAILURE ❌
• URL: https://build.ci.opensearch.org/job/gradle-check/25620/
• CommitID: 03b351d
  Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
  Is the failure a flaky test unrelated to your change?

[opensearch-trigger-bot]

This PR is stalled because it has been open for 30 days with no activity.

[andrross]

Looks like this has been abandoned. @sachinpkale Please reopen and rebase if you still want to commit this.