-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix flaky test SearchRestCancellationIT.testAutomaticCancellationMultiSearchDuringFetchPhase
#7985
Merged
dblock
merged 6 commits into
opensearch-project:main
from
stephen-crawford:restCancellation
Jun 13, 2023
Merged
Fix flaky test SearchRestCancellationIT.testAutomaticCancellationMultiSearchDuringFetchPhase
#7985
dblock
merged 6 commits into
opensearch-project:main
from
stephen-crawford:restCancellation
Jun 13, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Stephen Crawford <[email protected]>
Signed-off-by: Stephen Crawford <[email protected]>
stephen-crawford
requested review from
reta,
anasalkouz,
andrross,
Bukhtawar,
CEHENKLE,
dblock,
gbbafna,
setiah,
kartg,
kotwanikunal,
mch2,
nknize,
owaiskazi19,
Rishikesh1159,
ryanbogan,
saratvemulapalli,
shwetathareja,
dreamer-89,
tlfeng,
VachaShah and
dbwiddis
as code owners
June 9, 2023 14:54
Signed-off-by: Stephen Crawford <[email protected]>
Signed-off-by: Stephen Crawford <[email protected]>
Gradle Check (Jenkins) Run Completed with:
|
Signed-off-by: Stephen Crawford <[email protected]>
Gradle Check (Jenkins) Run Completed with:
|
Codecov Report
@@ Coverage Diff @@
## main #7985 +/- ##
============================================
+ Coverage 70.84% 70.99% +0.15%
- Complexity 56452 56551 +99
============================================
Files 4714 4714
Lines 267213 267213
Branches 39182 39182
============================================
+ Hits 189294 189709 +415
+ Misses 61918 61438 -480
- Partials 16001 16066 +65 |
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Looks like the previous change to correct this test did not work... |
BhumikaSaini-Amazon
approved these changes
Jun 10, 2023
dbwiddis
approved these changes
Jun 10, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jun 13, 2023
…tiSearchDuringFetchPhase` (#7985) * add latch.await Signed-off-by: Stephen Crawford <[email protected]> * remove space Signed-off-by: Stephen Crawford <[email protected]> * Fix await timing Signed-off-by: Stephen Crawford <[email protected]> * fix line Signed-off-by: Stephen Crawford <[email protected]> * shorten await Signed-off-by: Stephen Crawford <[email protected]> --------- Signed-off-by: Stephen Crawford <[email protected]> (cherry picked from commit df517a6) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
kotwanikunal
pushed a commit
that referenced
this pull request
Jun 13, 2023
…tiSearchDuringFetchPhase` (#7985) (#8042) * add latch.await * remove space * Fix await timing * fix line * shorten await --------- (cherry picked from commit df517a6) Signed-off-by: Stephen Crawford <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
gaiksaya
pushed a commit
to gaiksaya/OpenSearch
that referenced
this pull request
Jun 15, 2023
…tiSearchDuringFetchPhase` (opensearch-project#7985) * add latch.await Signed-off-by: Stephen Crawford <[email protected]> * remove space Signed-off-by: Stephen Crawford <[email protected]> * Fix await timing Signed-off-by: Stephen Crawford <[email protected]> * fix line Signed-off-by: Stephen Crawford <[email protected]> * shorten await Signed-off-by: Stephen Crawford <[email protected]> --------- Signed-off-by: Stephen Crawford <[email protected]>
gaiksaya
pushed a commit
to gaiksaya/OpenSearch
that referenced
this pull request
Jun 26, 2023
…tiSearchDuringFetchPhase` (opensearch-project#7985) (opensearch-project#8042) * add latch.await * remove space * Fix await timing * fix line * shorten await --------- (cherry picked from commit df517a6) Signed-off-by: Stephen Crawford <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
imRishN
pushed a commit
to imRishN/OpenSearch
that referenced
this pull request
Jun 27, 2023
…tiSearchDuringFetchPhase` (opensearch-project#7985) * add latch.await Signed-off-by: Stephen Crawford <[email protected]> * remove space Signed-off-by: Stephen Crawford <[email protected]> * Fix await timing Signed-off-by: Stephen Crawford <[email protected]> * fix line Signed-off-by: Stephen Crawford <[email protected]> * shorten await Signed-off-by: Stephen Crawford <[email protected]> --------- Signed-off-by: Stephen Crawford <[email protected]> Signed-off-by: Rishab Nahata <[email protected]>
shiv0408
pushed a commit
to Gaurav614/OpenSearch
that referenced
this pull request
Apr 25, 2024
…tiSearchDuringFetchPhase` (opensearch-project#7985) * add latch.await Signed-off-by: Stephen Crawford <[email protected]> * remove space Signed-off-by: Stephen Crawford <[email protected]> * Fix await timing Signed-off-by: Stephen Crawford <[email protected]> * fix line Signed-off-by: Stephen Crawford <[email protected]> * shorten await Signed-off-by: Stephen Crawford <[email protected]> --------- Signed-off-by: Stephen Crawford <[email protected]> Signed-off-by: Shivansh Arora <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR seeks to correct a flaky test
SearchRestCancellationIT.testAutomaticCancellationMultiSearchDuringFetchPhase
.In the test, a multisearch REST request is created and then cancelled. The test sometimes fails on a runner because the latch had not been set to await for its countdown. By adding the
latch.await(2, Seconds)
statement the latch should force the following blockto perform the asynchronous request before continuing. This should mean that even on a faster runner, the request will have had to execute before the later assertion can be checked.
Related Issues
Resolves #7980
Check List
New functionality includes testing.All tests passNew functionality has been documented.New functionality has javadoc addedCommit changes are listed out in CHANGELOG.md file (See: Changelog)By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.