[Backport 2.x] Moving concurrent-search out of sandbox plugin to core behind feature… #7408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kotwanikunal
requested review from
reta,
anasalkouz,
andrross,
Bukhtawar,
CEHENKLE,
dblock,
gbbafna,
setiah,
kartg,
mch2,
nknize,
owaiskazi19,
Rishikesh1159,
ryanbogan,
saratvemulapalli,
shwetathareja,
dreamer-89,
tlfeng and
VachaShah
as code owners
kotwanikunal
force-pushed
the
backport-7203
branch
from
fa6e7c1 to
5e7f5f6
Compare
6 tasks
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
… flag (opensearch-project#7203) Signed-off-by: Sorabh Hamirwasia <[email protected]> (cherry picked from commit fde8fa4) Signed-off-by: Kunal Kotwani <[email protected]>
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## 2.x #7408 +/- ##
============================================
- Coverage 70.28% 70.25% -0.03%
+ Complexity 59750 59670 -80
============================================
Files 4864 4863 -1
Lines 287384 287391 +7
Branches 41744 41748 +4
============================================
- Hits 201988 201916 -72
+ Misses 68568 68528 -40
- Partials 16828 16947 +119
|
kotwanikunal
force-pushed
the
backport-7203
branch
from
5e7f5f6 to
bf1e8e9
Compare
reta
reviewed
May 3, 2023
| @@ -31,4 +34,5 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/), | |||
|
|
|||
| ### Security | |||
|
|
|||
|
|
|||
| [Unreleased 3.0]: https://github.com/opensearch-project/OpenSearch/compare/2.x...HEAD | |||
There was a problem hiding this comment.
I will remove it with a new PR.
reta
reviewed
May 3, 2023
| @@ -5,9 +5,10 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/), | |||
|
|
|||
| ## [Unreleased 2.x] | |||
| ### Added | |||
| - [Extensions] Moving Extensions APIs to support cross versions via protobuf. ([#6960](https://github.com/opensearch-project/OpenSearch/pull/6960)) | |||
| - [Extensions] Moving Extensions APIs to support cross versions via protobuf. ([#7402](https://github.com/opensearch-project/OpenSearch/issues/7402)) | |||
There was a problem hiding this comment.
The changelog looks a bit messed up
There was a problem hiding this comment.
My bad @reta. I've started merging in more PRs but it didn't make sense for readers as all of them are just moving these APIs to support cross versions. So I've just moved it to meta issue and updated main and 2.x CHANGELOG to reflect the meta issue instead of individual PRs.
6 tasks
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
tlfeng
approved these changes
May 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… flag (#7203)
Signed-off-by: Sorabh Hamirwasia [email protected]
(cherry picked from commit fde8fa4)
Description
2.xRelated Issues
N/A
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.