Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Manually backport: Introduce Identity Plugin to Core (#7246) #7393

Merged
merged 3 commits into from
May 3, 2023

Conversation

stephen-crawford
Copy link
Contributor

Manually backports #7246 to 2.x line.

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

* Identity and access control for OpenSearch

Adding a new service and plugin interface that provides identity and access control inside of OpenSearch. This is the founding building block, see more high level thoughts here on our recent blog. https://opensearch.org/blog/Introducing-Identity/

The new extension point, IdentityPlugin, is added with IdentityService handling that plugin interface. IdentityService authenticates users and enables access control systems. Adding HTTP basic authentication in the RestController the default NoopIdentityPlugin changes no behavior.

Signed-off-by: Stephen Crawford <[email protected]>
Signed-off-by: Peter Nied <[email protected]>
Co-authored-by: Peter Nied <[email protected]>
Co-authored-by: Andriy Redko <[email protected]>
Signed-off-by: Stephen Crawford <[email protected]>
@github-actions
Copy link
Contributor

github-actions bot commented May 3, 2023

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

github-actions bot commented May 3, 2023

Gradle Check (Jenkins) Run Completed with:

Signed-off-by: Stephen Crawford <[email protected]>
@github-actions
Copy link
Contributor

github-actions bot commented May 3, 2023

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      2 org.opensearch.search.SearchWeightedRoutingIT.testStrictWeightedRoutingWithCustomString

@codecov-commenter
Copy link

Codecov Report

Merging #7393 (62947d0) into 2.x (d88c4a6) will decrease coverage by 0.13%.
The diff coverage is 52.02%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@             Coverage Diff              @@
##                2.x    #7393      +/-   ##
============================================
- Coverage     70.36%   70.24%   -0.13%     
- Complexity    59753    59763      +10     
============================================
  Files          4850     4864      +14     
  Lines        287213   287384     +171     
  Branches      41727    41744      +17     
============================================
- Hits         202100   201867     -233     
- Misses        68217    68645     +428     
+ Partials      16896    16872      -24     
Impacted Files Coverage Δ
...opensearch/identity/shiro/ShiroIdentityPlugin.java 0.00% <0.00%> (ø)
...pensearch/identity/shiro/ShiroSecurityManager.java 0.00% <0.00%> (ø)
...identity/shiro/UnsupportedAuthenticationToken.java 0.00% <0.00%> (ø)
...pensearch/common/settings/FeatureFlagSettings.java 50.00% <ø> (ø)
...opensearch/identity/tokens/RestTokenExtractor.java 0.00% <0.00%> (ø)
.../main/java/org/opensearch/rest/RestController.java 75.64% <4.76%> (-6.99%) ⬇️
...java/org/opensearch/identity/noop/NoopSubject.java 22.22% <22.22%> (ø)
...va/org/opensearch/identity/shiro/ShiroSubject.java 44.44% <44.44%> (ø)
server/src/main/java/org/opensearch/node/Node.java 84.84% <50.00%> (-0.30%) ⬇️
...n/java/org/opensearch/identity/NamedPrincipal.java 54.54% <54.54%> (ø)
... and 10 more

... and 501 files with indirect coverage changes

@mch2 mch2 merged commit 175ea44 into opensearch-project:2.x May 3, 2023
@stephen-crawford stephen-crawford deleted the backportIdentity branch June 9, 2023 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants