Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds this PR to CHANGELOG #7098

Conversation

DarshitChanpura
Copy link
Member

Description

Updates changelog for dependabot PR

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

dependabot bot and others added 2 commits April 10, 2023 13:59
Bumps [com.netflix.nebula:gradle-extra-configurations-plugin](https://github.com/nebula-plugins/gradle-extra-configurations-plugin) from 9.0.0 to 10.0.0.
- [Release notes](https://github.com/nebula-plugins/gradle-extra-configurations-plugin/releases)
- [Changelog](https://github.com/nebula-plugins/gradle-extra-configurations-plugin/blob/main/CHANGELOG.md)
- [Commits](nebula-plugins/gradle-extra-configurations-plugin@v9.0.0...v10.0.0)

---
updated-dependencies:
- dependency-name: com.netflix.nebula:gradle-extra-configurations-plugin
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
Signed-off-by: Darshit Chanpura <[email protected]>
@kotwanikunal
Copy link
Member

I tried looking into #7068 . This needs more than just the changelog entry
./gradlew updateSHAs was failing as well.

@owaiskazi19
Copy link
Member

Can we add the changelog in #7068 itself and close this PR?

@kotwanikunal
Copy link
Member

@owaiskazi19 I am not sure if @DarshitChanpura will be able to directly update the branch because he is not a maintainer for the OpenSearch repo.

@owaiskazi19
Copy link
Member

owaiskazi19 commented Apr 11, 2023

@owaiskazi19 I am not sure if @DarshitChanpura will be able to directly update the branch because he is not a maintainer for the OpenSearch repo.

Ah, missed that. @DarshitChanpura are you fine if I push the change to the changelog on your behalf to #7068?

@DarshitChanpura
Copy link
Member Author

@owaiskazi19 I am not sure if @DarshitChanpura will be able to directly update the branch because he is not a maintainer for the OpenSearch repo.

Ah, missed that. @DarshitChanpura are you fine if I push the change to the changelog on your behalf to #7068?

Yes, sounds good. I was not able to do it directly because I'm not a maintainer.

@owaiskazi19 owaiskazi19 force-pushed the dependabot/gradle/buildSrc/com.netflix.nebula-gradle-extra-configurations-plugin-10.0.0 branch from b902071 to 376ad46 Compare April 12, 2023 17:04
@owaiskazi19
Copy link
Member

@DarshitChanpura @kotwanikunal I have added the changelog entry in #7068 and there's a build failure. Closing this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants