[Segment Replication] Cancellation check before send files to prevent… #7053
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… segrep round Signed-off-by: Suraj Singh <[email protected]>
dreamer-89
requested review from
reta,
anasalkouz,
andrross,
Bukhtawar,
CEHENKLE,
dblock,
gbbafna,
setiah,
kartg,
kotwanikunal,
mch2,
nknize,
owaiskazi19,
Rishikesh1159,
ryanbogan,
saratvemulapalli,
shwetathareja,
tlfeng,
VachaShah and
xuezhou25
as code owners
Gradle Check (Jenkins) Run Completed with:
|
Poojita-Raj
approved these changes
Apr 10, 2023
Rishikesh1159
approved these changes
Apr 10, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Apr 11, 2023
… segrep round (#7053) Signed-off-by: Suraj Singh <[email protected]> (cherry picked from commit df5def4) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
dreamer-89
pushed a commit
that referenced
this pull request
Apr 11, 2023
… segrep round (#7053) (#7112) (cherry picked from commit df5def4) Signed-off-by: Suraj Singh <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
austintlee
pushed a commit
to austintlee/OpenSearch
that referenced
this pull request
Apr 28, 2023
… segrep round (opensearch-project#7053) Signed-off-by: Suraj Singh <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… segrep round
Description
Cancel segment replication when shard not in primary mode. This ensures that shards not in primary mode and cancelled on source by respective event listeners should not proceed with next steps on segment replication.
Issues Resolved
Resolves #6778
Alternative
Run sequential code block inside cancellableThreads.execute() which can be interrupted on shard changes. This will need little more refactoring and thought around resource handling (close operations etc), we can take this up as follow up.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.