Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add remark field to NodeData and TaskInfo #6553

Conversation

XiaochenNan
Copy link
Contributor

@XiaochenNan XiaochenNan commented Mar 6, 2023

Description

add remark field to NodeData and TaskInfo

Issues Resolved

[#6552]

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@XiaochenNan XiaochenNan changed the title add remark field to NodeData and TaskInfo (#6552) add remark field to NodeData and TaskInfo Mar 6, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Mar 6, 2023

Gradle Check (Jenkins) Run Completed with:

@XiaochenNan XiaochenNan force-pushed the add-remark-to-NodeData-and-TaskInfo branch from 7966cfc to 644d6ff Compare March 7, 2023 02:50
@github-actions
Copy link
Contributor

github-actions bot commented Mar 7, 2023

Gradle Check (Jenkins) Run Completed with:

XiaochenNan and others added 2 commits March 7, 2023 21:15
Signed-off-by: Nan Xiaochen <[email protected]>
Signed-off-by: brian <[email protected]>
Signed-off-by: Nan Xiaochen <[email protected]>
Signed-off-by: brian <[email protected]>
@github-actions
Copy link
Contributor

github-actions bot commented Mar 7, 2023

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

github-actions bot commented Mar 7, 2023

Gradle Check (Jenkins) Run Completed with:

Signed-off-by: Nan Xiaochen <[email protected]>
Signed-off-by: brian <[email protected]>
@github-actions
Copy link
Contributor

github-actions bot commented Mar 7, 2023

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      1 org.opensearch.cluster.routing.WeightedRoutingIT.testClusterHealthResponseWithEnsureNodeWeighedInParam

Copy link
Member

@saratvemulapalli saratvemulapalli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @XiaochenNan for contributing a change.

Trying to understand, what do intend to use this field for which attributes is unable to serve?
Also it would be great if you could add tests.

@XiaochenNan
Copy link
Contributor Author

XiaochenNan commented Mar 10, 2023

@saratvemulapalli
just want to get the remark info in first level of data, then user can get it without analyze the key in attributes

@saratvemulapalli
Copy link
Member

@saratvemulapalli just want to get the remark info in first level of data, then user can get it without analyze the key in attributes

Thanks @XiaochenNan. I am not really seeing value of adding a new field but I would like to hear from other maintainers @anasalkouz @reta @andrross @dblock @nknize

@andrross
Copy link
Member

@XiaochenNan Can you explain the problem this solution is trying to solve? "user may need set more additional infomation in NodeData and TaskInfo data" from the linked issue isn't nearly detailed enough. What is the problem that leads to a user needing addition information in NodeData and TaskInfo? Once the problem is clear we can start evaluating solutions.

@opensearch-trigger-bot
Copy link
Contributor

This PR is stalled because it has been open for 30 days with no activity. Remove stalled label or comment or this will be closed in 7 days.

@opensearch-trigger-bot opensearch-trigger-bot bot added the stalled Issues that have stalled label Jul 6, 2023
@opensearch-trigger-bot
Copy link
Contributor

This PR was closed because it has been stalled for 7 days with no activity.

@kotwanikunal
Copy link
Member

Apologies. This PR was auto closed without reaching a resolution from the maintainers.
Re-opening to move it forward.
Thanks for your contributions to OpenSearch!

@codecov
Copy link

codecov bot commented Sep 14, 2023

Codecov Report

Merging #6553 (06204ea) into main (5afc24f) will decrease coverage by 0.08%.
Report is 888 commits behind head on main.
The diff coverage is 9.52%.

@@             Coverage Diff              @@
##               main    #6553      +/-   ##
============================================
- Coverage     70.76%   70.68%   -0.08%     
+ Complexity    59122    59087      -35     
============================================
  Files          4804     4804              
  Lines        283096   283116      +20     
  Branches      40811    40813       +2     
============================================
- Hits         200326   200131     -195     
- Misses        66388    66555     +167     
- Partials      16382    16430      +48     
Files Changed Coverage Δ
...ain/java/org/opensearch/client/tasks/NodeData.java 44.11% <6.66%> (-9.59%) ⬇️
...ain/java/org/opensearch/client/tasks/TaskInfo.java 59.78% <16.66%> (-3.01%) ⬇️

... and 509 files with indirect coverage changes

@github-actions
Copy link
Contributor

Compatibility status:

Checks if related components are compatible with change 06204ea

Incompatible components

Skipped components

Compatible components

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@ashking94
Copy link
Member

@XiaochenNan - Is this being worked upon? Please reach out to the maintainers and other active members to reach conclusion or reviews.

@ticheng-aws
Copy link
Contributor

Hi @XiaochenNan, do we have any updates on this PR?

@opensearch-trigger-bot opensearch-trigger-bot bot removed the stalled Issues that have stalled label Jan 15, 2024
@andrross
Copy link
Member

andrross commented Feb 9, 2024

I'm closing this due to no response to the questions above. @XiaochenNan feel free to respond to the feedback and reopen if appropriate. Thanks!

@andrross andrross closed this Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants