-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add remark field to NodeData and TaskInfo #6553
add remark field to NodeData and TaskInfo #6553
Conversation
Gradle Check (Jenkins) Run Completed with:
|
Signed-off-by: nanxc1 <[email protected]>
7966cfc
to
644d6ff
Compare
Gradle Check (Jenkins) Run Completed with:
|
Signed-off-by: Nan Xiaochen <[email protected]> Signed-off-by: brian <[email protected]>
Signed-off-by: Nan Xiaochen <[email protected]> Signed-off-by: brian <[email protected]>
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Signed-off-by: Nan Xiaochen <[email protected]> Signed-off-by: brian <[email protected]>
Gradle Check (Jenkins) Run Completed with:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @XiaochenNan for contributing a change.
Trying to understand, what do intend to use this field for which attributes
is unable to serve?
Also it would be great if you could add tests.
@saratvemulapalli |
Thanks @XiaochenNan. I am not really seeing value of adding a new field but I would like to hear from other maintainers @anasalkouz @reta @andrross @dblock @nknize |
@XiaochenNan Can you explain the problem this solution is trying to solve? "user may need set more additional infomation in NodeData and TaskInfo data" from the linked issue isn't nearly detailed enough. What is the problem that leads to a user needing addition information in NodeData and TaskInfo? Once the problem is clear we can start evaluating solutions. |
This PR is stalled because it has been open for 30 days with no activity. Remove stalled label or comment or this will be closed in 7 days. |
This PR was closed because it has been stalled for 7 days with no activity. |
Apologies. This PR was auto closed without reaching a resolution from the maintainers. |
Codecov Report
@@ Coverage Diff @@
## main #6553 +/- ##
============================================
- Coverage 70.76% 70.68% -0.08%
+ Complexity 59122 59087 -35
============================================
Files 4804 4804
Lines 283096 283116 +20
Branches 40811 40813 +2
============================================
- Hits 200326 200131 -195
- Misses 66388 66555 +167
- Partials 16382 16430 +48
|
Compatibility status:Checks if related components are compatible with change 06204ea Incompatible componentsSkipped componentsCompatible components |
Gradle Check (Jenkins) Run Completed with:
|
@XiaochenNan - Is this being worked upon? Please reach out to the maintainers and other active members to reach conclusion or reviews. |
Hi @XiaochenNan, do we have any updates on this PR? |
I'm closing this due to no response to the questions above. @XiaochenNan feel free to respond to the feedback and reopen if appropriate. Thanks! |
Description
add remark field to NodeData and TaskInfo
Issues Resolved
[#6552]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.