power changes for building with and without jdk #5950
Conversation
SonalMahambrey1
requested review from
reta,
anasalkouz,
andrross,
Bukhtawar,
CEHENKLE,
dblock,
gbbafna,
setiah,
kartg,
kotwanikunal,
mch2,
nknize,
owaiskazi19,
adnapibar,
Rishikesh1159,
ryanbogan,
saratvemulapalli,
shwetathareja,
dreamer-89,
tlfeng,
VachaShah and
xuezhou25
as code owners
Gradle Check (Jenkins) Run Completed with:
|
|
@SonalMahambrey1 could you please fix DCO check and update CHANGELOG? Please check https://github.com/opensearch-project/OpenSearch/blob/main/CONTRIBUTING.md#developer-certificate-of-origin |
@reta I'm fine with skipping the CHANGELOG entry for a build-related change like this. What do you think? |
|
Added DCO |
Looks like it's incorrect. Make sure you have a valid e-mail in your git config: Then |
Signed-off-by: Sonal-Mahambrey1 <[email protected]>
SonalMahambrey1
force-pushed
the
sonal-powerchanges
branch
from
0b9037c to
df25f63
Compare
Gradle Check (Jenkins) Run Completed with:
|
Tests with failures:
org.opensearch.grok.GrokTests > testExponentialExpressions FAILED org.opensearch.grok.GrokTests > classMethod FAILED |
LGTM, thanks @SonalMahambrey1 ! |
Gradle Check (Jenkins) Run Completed with:
|
|
@SonalMahambrey1 could you please rebase? |
|
Done |
Gradle Check (Jenkins) Run Completed with:
|
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #5950 +/- ##
============================================
+ Coverage 70.64% 70.84% +0.20%
- Complexity 58656 58846 +190
============================================
Files 4780 4780
Lines 281380 281380
Branches 40635 40635
============================================
+ Hits 198769 199348 +579
+ Misses 66191 65649 -542
+ Partials 16420 16383 -37
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
reta
added
backport 1.x
backport 2.x
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-1.3 1.3
# Navigate to the new working tree
pushd ../.worktrees/backport-1.3
# Create a new branch
git switch --create backport/backport-5950-to-1.3
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 83dccad312faa7d9350ffa6672e51d02d36ad06f
# Push it to GitHub
git push --set-upstream origin backport/backport-5950-to-1.3
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-1.3Then, create a pull request where the |
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-1.x 1.x
# Navigate to the new working tree
pushd ../.worktrees/backport-1.x
# Create a new branch
git switch --create backport/backport-5950-to-1.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 83dccad312faa7d9350ffa6672e51d02d36ad06f
# Push it to GitHub
git push --set-upstream origin backport/backport-5950-to-1.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-1.xThen, create a pull request where the |
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.5 2.5
# Navigate to the new working tree
pushd ../.worktrees/backport-2.5
# Create a new branch
git switch --create backport/backport-5950-to-2.5
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 83dccad312faa7d9350ffa6672e51d02d36ad06f
# Push it to GitHub
git push --set-upstream origin backport/backport-5950-to-2.5
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.5Then, create a pull request where the |
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-5950-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 83dccad312faa7d9350ffa6672e51d02d36ad06f
# Push it to GitHub
git push --set-upstream origin backport/backport-5950-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.xThen, create a pull request where the |
|
@SonalMahambrey1 would you take care of backports please? |
|
very likely :( I will take care of that, thanks a lot @andrross ! |
Signed-off-by: Sonal-Mahambrey1 <[email protected]>
Signed-off-by: Sonal Mahambrey [Sonal Mahambrey1 [email protected])
Description
Added changes to build snapshot for power with and without JDK
Issues Resolved
./gradlew :distribution:archives:linux-ppc64le-tar:assemble
The command used to create the snapshot without JDK and there was no support for creating snapshot with JDK
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.