-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Identity and access control foundation for OpenSearch #5925
Closed
Closed
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,66 @@ | ||
| /* | ||
| * SPDX-License-Identifier: Apache-2.0 | ||
| * | ||
| * The OpenSearch Contributors require contributions made to | ||
| * this file be licensed under the Apache-2.0 license or a | ||
| * compatible open source license. | ||
| */ | ||
|
|
||
| apply plugin: 'opensearch.internal-cluster-test' | ||
|
|
||
| opensearchplugin { | ||
| description 'Plugin for identity features in OpenSearch.' | ||
| classname 'org.opensearch.identity.shiro.ShiroIdentityPlugin' | ||
| name project.name | ||
| licenseFile rootProject.file('licenses/APACHE-LICENSE-2.0.txt') | ||
| noticeFile rootProject.file('NOTICE.txt') | ||
| } | ||
|
|
||
| dependencies { | ||
| implementation 'org.apache.shiro:shiro-core:1.9.1' | ||
| // Needed for shiro | ||
| implementation "org.slf4j:slf4j-api:${versions.slf4j}" | ||
|
|
||
| implementation 'commons-beanutils:commons-beanutils:1.9.4' | ||
| implementation 'commons-logging:commons-logging:1.2' | ||
| implementation 'commons-lang:commons-lang:2.6' | ||
|
|
||
| implementation "org.bouncycastle:bcprov-jdk15on:${versions.bouncycastle}" | ||
|
|
||
| testImplementation project(path: ':modules:transport-netty4') // for http | ||
| testImplementation project(path: ':plugins:transport-nio') // for http | ||
| testImplementation "org.mockito:mockito-core:${versions.mockito}" | ||
| } | ||
peternied marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
||
| /* | ||
| * We have to disable setting the number of available processors as tests in the same JVM randomize processors and will step on each | ||
| * other if we allow them to set the number of available processors as it's set-once in Netty. | ||
| */ | ||
| test { | ||
| systemProperty 'opensearch.set.netty.runtime.available.processors', 'false' | ||
| } | ||
|
|
||
| internalClusterTest { | ||
| systemProperty 'opensearch.set.netty.runtime.available.processors', 'false' | ||
| } | ||
|
|
||
| thirdPartyAudit.ignoreMissingClasses( | ||
| 'javax.servlet.ServletContextEvent', | ||
| 'javax.servlet.ServletContextListener', | ||
| 'org.apache.avalon.framework.logger.Logger', | ||
| 'org.apache.commons.collections.Closure', | ||
| 'org.apache.commons.collections.FastHashMap', | ||
| 'org.apache.commons.collections.Predicate', | ||
| 'org.apache.commons.collections.Transformer', | ||
| 'org.apache.commons.collections.comparators.ComparableComparator', | ||
| 'org.apache.commons.collections.keyvalue.AbstractMapEntry', | ||
| 'org.apache.commons.configuration2.interpol.ConfigurationInterpolator', | ||
| 'org.apache.log.Hierarchy', | ||
| 'org.apache.log.Logger', | ||
| 'org.apache.log4j.Level', | ||
| 'org.apache.log4j.Logger', | ||
| 'org.apache.log4j.Priority', | ||
| 'org.slf4j.impl.StaticLoggerBinder', | ||
| 'org.slf4j.impl.StaticMDCBinder', | ||
| 'org.slf4j.impl.StaticMarkerBinder' | ||
| ) | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| 4636a0d01f74acaf28082fb62b317f1080118371 |
22 changes: 22 additions & 0 deletions
22
modules/identity-shiro/licenses/bcprov-jdk15on-LICENSE.txt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| The MIT License (MIT) | ||
|
|
||
| Copyright (c) 2000 - 2013 The Legion of the Bouncy Castle Inc. | ||
| (http://www.bouncycastle.org) | ||
|
|
||
| Permission is hereby granted, free of charge, to any person obtaining a copy | ||
| of this software and associated documentation files (the "Software"), to deal | ||
| in the Software without restriction, including without limitation the rights | ||
| to use, copy, modify, merge, publish, distribute, sublicense, and/or sell | ||
| copies of the Software, and to permit persons to whom the Software is | ||
| furnished to do so, subject to the following conditions: | ||
|
|
||
| The above copyright notice and this permission notice shall be included in | ||
| all copies or substantial portions of the Software. | ||
|
|
||
| THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR | ||
| IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, | ||
| FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE | ||
| AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER | ||
| LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, | ||
| OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN | ||
| THE SOFTWARE. |
Empty file.
1 change: 1 addition & 0 deletions
1
modules/identity-shiro/licenses/commons-beanutils-1.9.4.jar.sha1
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| d52b9abcd97f38c81342bb7e7ae1eee9b73cba51 |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this module will be an ideal candidate for
sandbox?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are a couple of ways to introduce non-GA features into OpenSearch, sandbox changes the build output which is easy to test locally, but difficult from the distribution channels. Using feature flags was recently introduced and is easier to control outside this repository. What do you think of this tradeoff to include the module but have it disabled via feature flag?
OpenSearch/server/src/main/java/org/opensearch/common/util/FeatureFlags.java
Line 60 in 81af972
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe there are 2 parts to it:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 I'll move the module into sandbox
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@peternied Feel free to weigh in on #3677