[Backport 2.x] Add support for API versioning and fail open in weighted shard routing #5781
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… weights in the response (opensearch-project#5680) * Add support for discovered master and remove local weights in the weighted routing API response Signed-off-by: Anshu Agarwal <[email protected]>
* Support API versioning for weighted shard routing Signed-off-by: Anshu Agarwal <[email protected]>
…pensearch-project#5072) * Fail open requests on search shard failures ( Signed-off-by: Anshu Agarwal <[email protected]>
anshu1106
requested review from
reta,
anasalkouz,
andrross,
Bukhtawar,
CEHENKLE,
dblock,
gbbafna,
setiah,
kartg,
kotwanikunal,
mch2,
nknize,
owaiskazi19,
adnapibar,
Rishikesh1159,
ryanbogan,
saratvemulapalli,
shwetathareja,
dreamer-89,
tlfeng,
VachaShah and
xuezhou25
as code owners
Gradle Check (Jenkins) Run Completed with:
|
[Weighted Shard Routing] Refactor and fix singleton in FailAwareWeightedRouting Signed-off-by: Anshu Agarwal <[email protected]>
Gradle Check (Jenkins) Run Completed with:
|
Signed-off-by: Anshu Agarwal <[email protected]>
gbbafna
approved these changes
Jan 10, 2023
Gradle Check (Jenkins) Run Completed with:
|
Bukhtawar
reviewed
Jan 10, 2023
Comment on lines
+53
to
+57
| version = in.readLong(); | ||
| if (in.available() != 0) { | ||
| awarenessAttribute = in.readString(); | ||
| } | ||
| } |
There was a problem hiding this comment.
Can we add a check to read these params only if OpenSearch version is 2.5 and above else there is a possibility that mixed version cluster tests will fail with serde issues. We might want to do the same in main as well.
There was a problem hiding this comment.
Since the apis are marked experimental, do you think we should put effort on this. The change will require effort and testing to make both the flows work.
Even if we just fix the serialization/deserialization the request will fail eventually due to version mismatch. There is a non trivial problem to address version update in cluster metadata since few nodes(2.5 and above) may support versioning and others won't. So if we need to support mixed clusters, we have to build backward compatibility ie enable/disable versioning support for the entire cluster
As per OpenSearch doc, we can break experimental apis
#5255 (comment)
Gradle Check (Jenkins) Run Completed with:
|
Build failed due to flaky test failure - #5765 |
|
Test Failure : #5765 |
kotwanikunal
pushed a commit
that referenced
this pull request
Jan 25, 2023
…ed shard routing (#5781) * [Backport 2.x] [Weighted Shard Routing] Add support for discovered master and remove local weights in the response #5680 [Weighted Shard Routing] API versioning #5255 [Weighted Shard Routing] Fail open requests on search shard failures #5072 [Weighted Shard Routing] Refactor and fix singleton in FailAwareWeightedRouting #5778 Signed-off-by: Anshu Agarwal <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Backport PR for weighted routing changes
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.