Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Better plural stemmer than minimal_english (#4738) #4834

Merged
merged 1 commit into from
Oct 19, 2022

Conversation

nknize
Copy link
Collaborator

@nknize nknize commented Oct 19, 2022

Backport c92846d from #4738

@nknize nknize added enhancement Enhancement or improvement to existing feature or request backport PRs or issues specific to backporting features or enhancments Indexing & Search v2.4.0 'Issues and PRs related to version v2.4.0' labels Oct 19, 2022
@nknize nknize requested review from a team and reta as code owners October 19, 2022 01:45
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@nknize
Copy link
Collaborator Author

nknize commented Oct 19, 2022

Last failure fixed by #4833

Drops the trailing "e" in taxes, dresses, watches, dishes etc that otherwise
cause mismatches with plural and singular forms.

Signed-off-by: Nicholas Walter Knize <[email protected]>

Co-authored-by: Mark Harwood <[email protected]>
Co-authored-by: Nicholas Walter Knize <[email protected]>
(cherry picked from commit c92846d)
@nknize nknize force-pushed the backport/backport-4738-to-2.x branch from 3bdab50 to 8fe8518 Compare October 19, 2022 14:12
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@nknize
Copy link
Collaborator Author

nknize commented Oct 19, 2022

#4259 & #4069

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@codecov-commenter
Copy link

Codecov Report

Merging #4834 (8fe8518) into 2.x (e53e6ad) will increase coverage by 0.03%.
The diff coverage is 86.88%.

@@             Coverage Diff              @@
##                2.x    #4834      +/-   ##
============================================
+ Coverage     70.69%   70.73%   +0.03%     
+ Complexity    57493    57482      -11     
============================================
  Files          4617     4618       +1     
  Lines        276033   276094      +61     
  Branches      40387    40405      +18     
============================================
+ Hits         195145   195292     +147     
+ Misses        64570    64470     -100     
- Partials      16318    16332      +14     
Impacted Files Coverage Δ
...rch/analysis/common/StemmerTokenFilterFactory.java 7.81% <50.00%> (+1.46%) ⬆️
...earch/analysis/common/EnglishPluralStemFilter.java 88.13% <88.13%> (ø)
...search/indices/recovery/RecoveryTargetHandler.java 0.00% <0.00%> (-100.00%) ⬇️
...opensearch/persistent/PersistentTasksExecutor.java 22.22% <0.00%> (-44.45%) ⬇️
...h/action/ingest/SimulateDocumentVerboseResult.java 60.71% <0.00%> (-39.29%) ⬇️
...java/org/opensearch/threadpool/ThreadPoolInfo.java 56.25% <0.00%> (-37.50%) ⬇️
...nsearch/index/shard/IndexShardClosedException.java 66.66% <0.00%> (-33.34%) ⬇️
...rc/main/java/org/opensearch/ingest/IngestInfo.java 51.72% <0.00%> (-27.59%) ⬇️
...a/org/opensearch/index/mapper/MapperException.java 75.00% <0.00%> (-25.00%) ⬇️
...nsearch/index/shard/IndexingOperationListener.java 63.93% <0.00%> (-22.96%) ⬇️
... and 456 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@nknize nknize merged commit a44370d into opensearch-project:2.x Oct 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport PRs or issues specific to backporting features or enhancments enhancement Enhancement or improvement to existing feature or request Indexing & Search v2.4.0 'Issues and PRs related to version v2.4.0'
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants