-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for ppc64, ppc64le and riscv64 architectures #3930
Conversation
Signed-off-by: Daniel Widdis <[email protected]>
Gradle Check (Jenkins) Run Completed with:
|
Signed-off-by: Daniel Widdis <[email protected]>
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Codecov Report
@@ Coverage Diff @@
## main #3930 +/- ##
============================================
+ Coverage 70.46% 70.50% +0.04%
- Complexity 56600 56628 +28
============================================
Files 4557 4563 +6
Lines 272737 272755 +18
Branches 40040 40040
============================================
+ Hits 192188 192310 +122
+ Misses 64324 64233 -91
+ Partials 16225 16212 -13
Continue to review full report at Codecov.
|
Gradle Check (Jenkins) Run Completed with:
|
Converting this to a draft to discuss the appropriate handling of these architectures in the I initially submitted this based on the fact that OpenSearch could be built by mapping these distributions to X64. However, looking further at where this enum is used, it seems to impact:
|
Signed-off-by: Daniel Widdis <[email protected]>
Gradle Check (Jenkins) Run Completed with:
|
Closing this as it's completely insufficient. A proper solution may be similar to #4000. |
Signed-off-by: Daniel Widdis [email protected]
Description
Properly parses the Architecture enum when building for ppc64, ppc64le, and RISC-V 64 architectures.
Issues Resolved
Fixes #1303. Fixes #2341. Supersedes PR #3435.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.