Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove old license header from new files created during master terminology replacement #3924

Closed

Conversation

tlfeng
Copy link
Collaborator

@tlfeng tlfeng commented Jul 15, 2022

Description

  • Remove the old license header from newly created class files. The files are created during master terminology replacement to maintain the backwards compatibility of the public classes.

Class file list:
MasterNodeOperationRequestBuilder
MasterNodeReadOperationRequestBuilder
MasterNodeReadRequest
MasterNodeRequest
TransportMasterNodeAction
TransportMasterNodeReadAction
NoMasterBlockService
UnsafeBootstrapMasterCommand
LocalNodeMasterListener
MasterNodeChangePredicate
NotMasterException
MasterNotDiscoveredException
RestMasterAction

Issues Resolved

Comes from #3914 (comment)

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@tlfeng tlfeng requested review from a team and reta as code owners July 15, 2022 18:01
@tlfeng tlfeng added v3.0.0 Issues and PRs related to version 3.0.0 backport 2.x Backport to 2.x branch v2.2.0 labels Jul 15, 2022
@tlfeng
Copy link
Collaborator Author

tlfeng commented Jul 15, 2022

@dreamer-89 Thanks a lot for your rapid review! 👍👍

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@tlfeng
Copy link
Collaborator Author

tlfeng commented Jul 15, 2022

In build 696:

> Task :server:internalClusterTest

REPRODUCE WITH: ./gradlew ':server:internalClusterTest' --tests "org.opensearch.index.ShardIndexingPressureSettingsIT.testShardIndexingPressureEnforcedEnabledDisabledSetting" -Dtests.seed=17073FD017DD65FD -Dtests.security.manager=true -Dtests.jvm.argline="-XX:TieredStopAtLevel=1 -XX:ReservedCodeCacheSize=64m" -Dtests.locale=sq-AL -Dtests.timezone=Asia/Karachi -Druntime.java=17

org.opensearch.index.ShardIndexingPressureSettingsIT > testShardIndexingPressureEnforcedEnabledDisabledSetting FAILED
    java.lang.Exception: Test abandoned because suite timeout was reached.
        at __randomizedtesting.SeedInfo.seed([17073FD017DD65FD]:0)

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@dreamer-89
Copy link
Member

dreamer-89 commented Jul 15, 2022

Java heap space causing build failure. Even though the build marked successful. This is tracked in opensearch-project/opensearch-build#2324

> Task :qa:mixed-cluster:v2.2.0#bwcTest
> Task :qa:mixed-cluster:bwcTestSnapshots
> Task :qa:mixed-cluster:check
build complete, generating: /var/jenkins/workspace/gradle-check/search/build/697.tar.bz2

BUILD SUCCESSFUL in 24m 9s
2594 actionable tasks: 2580 executed, 2 from cache, 12 up-to-date

FAILURE: Build failed with an exception.

* What went wrong:
Java heap space

* Try:
> Run with --stacktrace option to get the stack trace.
> Run with --info or --debug option to get more log output.
> Run with --scan to get full insights.

* Get more help at https://help.gradle.org

BUILD FAILED in 24m 9s
Gradle Check Failed!

Copy link
Member

@owaiskazi19 owaiskazi19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's not change the license header for old files of ES

@tlfeng
Copy link
Collaborator Author

tlfeng commented Jul 16, 2022

Close this PR, because there is concern to remove the old license headers. Although the files are newly created, the file name is the same as those present in ES.

@tlfeng tlfeng closed this Jul 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch v2.2.0 v3.0.0 Issues and PRs related to version 3.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants