-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Type Removal] Remove TypeFieldMapper usage, remove support of _type
in searches and from LeafFieldsLookup
#3016
Conversation
Signed-off-by: Suraj Singh <[email protected]>
Signed-off-by: Suraj Singh <[email protected]>
_type
in searches and from LeafFieldsLookup
_type
in searches and from LeafFieldsLookup_type
in searches and from LeafFieldsLookup
Getting issues with gradle on ubuntu machine. Tried stopping/starting gradle but it didn't help.
|
start gradle check |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great! LGTM!
Since we're about to cut rc-1, I'd like to hold on backporting this to 2.0. But really looking forward to getting it into 2.0! |
++ We'll have the PR auto opened but block the merge to prevent it from going in prematurely. |
…` in searches and from LeafFieldsLookup (#3016) Removes TypeFieldMapper and _type support from searches Signed-off-by: Suraj Singh <[email protected]> (cherry picked from commit dbdee30)
…` in searches and from LeafFieldsLookup (#3016) Removes TypeFieldMapper and _type support from searches Signed-off-by: Suraj Singh <[email protected]> (cherry picked from commit dbdee30)
…` in searches and from LeafFieldsLookup (#3016) (#3018) Removes TypeFieldMapper and _type support from searches Signed-off-by: Suraj Singh <[email protected]> (cherry picked from commit dbdee30)
…` in searches and from LeafFieldsLookup (opensearch-project#3016) Removes TypeFieldMapper and _type support from searches Signed-off-by: Suraj Singh <[email protected]> (cherry picked from commit dbdee30)
…` in searches and from LeafFieldsLookup (#3016) (#3236) Removes TypeFieldMapper and _type support from searches Signed-off-by: Suraj Singh <[email protected]> (cherry picked from commit dbdee30)
Description
This change introduces following changes:
TypeFieldMapper
class. In order to keep changes limited, retainedTypeFieldMapper
class which is referred in multiple tests for storing nested paths. Once, [Remove] Type from nested fields using new metadata field mapper #3004 is merged; this class can be removed completely._type
value infield
ofexists
query returns all records #2989Issues Resolved
#2989
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.