Remove binary (class) files from the repository #2969
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andriy Redko <[email protected]>
|
@owaiskazi19 could you take a look please? thanks! |
nknize
approved these changes
Apr 19, 2022
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Apr 19, 2022
Signed-off-by: Andriy Redko <[email protected]> (cherry picked from commit 896b97e)
|
It's being generated by some part of the build, so should be added to .gitignore as well or we need to figure out a way to not generate it. |
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.0 2.0
# Navigate to the new working tree
cd .worktrees/backport-2.0
# Create a new branch
git switch --create backport/backport-2969-to-2.0
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 896b97e54df4e192a15994a1076a9d1d04312f74
# Push it to GitHub
git push --set-upstream origin backport/backport-2969-to-2.0
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.0Then, create a pull request where the |
reta
added a commit
that referenced
this pull request
Apr 19, 2022
Signed-off-by: Andriy Redko <[email protected]> (cherry picked from commit 896b97e) Co-authored-by: Andriy Redko <[email protected]>
Hey @reta! I missed this. Thanks for taking care of this. We also have to remove MissingDoclet.class from here. Created #3015 for the same. |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Andriy Redko [email protected]
Description
Probably by mistake, the binary files were committed in scope of #2875, removing those.
Issues Resolved
Part of #2857
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.