Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding asm to version file and upgrading #2933

Merged
merged 1 commit into from
Apr 18, 2022
Merged

Adding asm to version file and upgrading #2933

merged 1 commit into from
Apr 18, 2022

Conversation

VachaShah
Copy link
Collaborator

Signed-off-by: Vacha Shah [email protected]

Description

Extracting the asm version to version.properties file so we can ensure the version is uniformly upgraded.

Related to #2830 (review)

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@VachaShah VachaShah requested a review from a team as a code owner April 15, 2022 23:32
@VachaShah VachaShah mentioned this pull request Apr 15, 2022
Closed
@VachaShah VachaShah requested a review from nknize April 15, 2022 23:33
@VachaShah VachaShah mentioned this pull request Apr 15, 2022
Closed
@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Check success 9567ca2
Log 4541

Reports 4541

nknize
nknize approved these changes Apr 16, 2022
View reviewed changes
Copy link
Collaborator

@nknize nknize left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx @VachaShah!! LGTM

@tlfeng tlfeng added >upgrade Label used when upgrading library dependencies (e.g., Lucene) dependencies Pull requests that update a dependency file labels Apr 16, 2022
@saratvemulapalli saratvemulapalli added v3.0.0 Issues and PRs related to version 3.0.0 backport 2.x Backport to 2.x branch labels Apr 18, 2022
@saratvemulapalli saratvemulapalli merged commit fc378c7 into opensearch-project:main Apr 18, 2022
opensearch-trigger-bot bot pushed a commit that referenced this pull request Apr 18, 2022
@VachaShah @github-actions
Adding asm to version file and upgrading (#2933)
3f4448c 
Signed-off-by: Vacha Shah <[email protected]>
(cherry picked from commit fc378c7)
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Apr 18, 2022
Merged
saratvemulapalli pushed a commit that referenced this pull request Apr 18, 2022
@opensearch-trigger-bot @VachaShah
Adding asm to version file and upgrading (#2933) (#2951)
98af7e0 
Signed-off-by: Vacha Shah <[email protected]>
(cherry picked from commit fc378c7)

Co-authored-by: Vacha Shah <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saratvemulapalli saratvemulapalli saratvemulapalli approved these changes

@nknize nknize nknize approved these changes

Assignees
No one assigned
Labels
backport 2.x Backport to 2.x branch dependencies Pull requests that update a dependency file >upgrade Label used when upgrading library dependencies (e.g., Lucene) v3.0.0 Issues and PRs related to version 3.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@VachaShah @opensearch-ci-bot @nknize @saratvemulapalli @tlfeng