Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 2.x] Add request parameter 'cluster_manager_timeout' and deprecate 'master_timeout' - in Index APIs except index template APIs #2770

Merged
merged 1 commit into from
Apr 5, 2022
Merged

[Backport 2.x] Add request parameter 'cluster_manager_timeout' and deprecate 'master_timeout' - in Index APIs except index template APIs #2770

merged 1 commit into from
Apr 5, 2022

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 7aa496f from #2660

@github-actions
Add request parameter 'cluster_manager_timeout' and deprecate 'master…
bde147c 
…_timeout' - in Index APIs except index template APIs (#2660)

- Deprecate the request parameter `master_timeout` that used in Index APIs which have got the parameter.
(except index template APIs, which is addressed in PR #2678)
- Add alternative new request parameter `cluster_manager_timeout`.
- Add unit tests.

Signed-off-by: Tianli Feng <[email protected]>
(cherry picked from commit 7aa496f)
@opensearch-trigger-bot opensearch-trigger-bot bot requested a review from a team as a code owner April 5, 2022 17:48
@tlfeng tlfeng added backport PRs or issues specific to backporting features or enhancments v2.1.0 Issues and PRs related to version 2.1.0 labels Apr 5, 2022
@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure bde147c
Log 4205

Reports 4205

@tlfeng
Copy link
Collaborator

tlfeng commented Apr 5, 2022

In log 4205:

> Task :qa:remote-clusters:integTest
OpenJDK 64-Bit Server VM warning: Ignoring option --illegal-access=warn; support was removed in 17.0
WARNING: A terminally deprecated method in java.lang.System has been called
WARNING: System::setSecurityManager has been called by org.opensearch.bootstrap.BootstrapForTesting (file:/var/CITOOL/workflow/OpenSearch_CI/PR_Checks/Gradle_Check/search/test/framework/build/distributions/framework-2.1.0-SNAPSHOT.jar)
WARNING: Please consider reporting this to the maintainers of org.opensearch.bootstrap.BootstrapForTesting
WARNING: System::setSecurityManager will be removed in a future release

REPRODUCE WITH: ./gradlew ':qa:remote-clusters:integTest' --tests "org.opensearch.cluster.remote.test.RemoteClustersIT.testHAProxyModeConnectionWorks" -Dtests.seed=63997867D642F818 -Dtests.security.manager=true -Dtests.jvm.argline="-XX:TieredStopAtLevel=1 -XX:ReservedCodeCacheSize=64m" -Dtests.locale=es-SV -Dtests.timezone=ART -Druntime.java=17

org.opensearch.cluster.remote.test.RemoteClustersIT > testHAProxyModeConnectionWorks FAILED
    java.lang.AssertionError
        at __randomizedtesting.SeedInfo.seed([63997867D642F818:64EFADACEDC48E45]:0)
        at org.junit.Assert.fail(Assert.java:87)
        at org.junit.Assert.assertTrue(Assert.java:42)
        at org.junit.Assert.assertTrue(Assert.java:53)
        at org.opensearch.cluster.remote.test.RemoteClustersIT.testHAProxyModeConnectionWorks(RemoteClustersIT.java:125)

It's reported in #1703
re-run: start gradle check

@tlfeng tlfeng mentioned this pull request Apr 5, 2022
Merged
@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Check success bde147c
Log 4210

Reports 4210

@tlfeng tlfeng merged commit e5b669a into 2.x Apr 5, 2022
@tlfeng tlfeng deleted the backport/backport-2660-to-2.x branch April 5, 2022 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tlfeng tlfeng tlfeng approved these changes

Assignees
No one assigned
Labels
backport PRs or issues specific to backporting features or enhancments v2.1.0 Issues and PRs related to version 2.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@opensearch-ci-bot @tlfeng