Add Shadow jar publication to lang-painless module.

[mch2]

Signed-off-by: Marc Handalian [email protected]

Description

This change creates a shadow jar for asm dependencies so
that they do not conflict with direct asm dependencies from log4j AL2 patch.

This change also adds explicit task dependency order for generated tasks. This is breaking with latest gradle version that warns of implicit dependencies & -Werr enabled by default.

This also bumps all asm dependencies to version 9.2.

Issues Resolved

#2664

Check List

• New functionality includes testing.
  • All tests pass
• New functionality has been documented.
  • New functionality has javadoc added
• Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[opensearch-ci-bot]

❌   Gradle Check failure 27ff98590c5f1ff3ee87b4bcbe874714883c0899
Log 3960

Reports 3960

[opensearch-ci-bot]

❌   Gradle Check failure 9226ca3
Log 3965

Reports 3965

[mch2]

❌   Gradle Check failure 9226ca3 Log 3965

Reports 3965

Tests with failures:

• org.opensearch.cluster.remote.test.RemoteClustersIT.testHAProxyModeConnectionWorks

[mch2]

start gradle check

[opensearch-ci-bot]

✅   Gradle Check success 9226ca3
Log 3970

Reports 3970

[dblock]

Could you please explain in more detail what's going on here or in the original issue. This is pretty hard to grok.

[dbbaughe]

Any chance someone was relying on this dependency and using through lang-painless module?

#### implementation

Dependencies that are used by the project at compile and runtime but are not exposed as a compile dependency to other dependent projects. Dependencies added to the `implementation` configuration are considered an implementation detail that can be changed at a later date without affecting any dependent projects.

#### api

Dependencies that are used as compile and runtime dependencies of a project and are considered part of the external api of the project.

[mch2]

Its possible, will revisit this if performing our own shadowing is the right path fwd, I'm not convinced thats the case.

[mch2]

I've changed these back to api, but I don't think this will make a difference because we are rewriting the package namespace.

[dbbaughe]

I see these dependencies in the lang-expression module too (and a test logger), do we need to change there too?

[mch2]

Could you please explain in more detail what's going on here or in the original issue. This is pretty hard to grok.

Added a comment on the original issue. TLDR this rewrites the namespace of these dependencies so we are not attempting to load the system dependencies injected by the hotpatch that are causing the issue.

I see these dependencies in the lang-expression module too (and a test logger), do we need to change there too?

This is stumping me, I'm not able to repro the failure running check on lang-expression with the hotpatch enabled.

[opensearch-ci-bot]

❌   Gradle Check failure 842d07d
Log 4037

Reports 4037

[opensearch-ci-bot]

✅   Gradle Check success b38919e
Log 4038

Reports 4038

[dblock]

@mch2 Will we want to revert this at some point when the hot patching issue is generally fixed? open an issue?

[mch2]

@mch2 Will we want to revert this at some point when the hot patching issue is generally fixed? open an issue?

Yes imo we should revert - added issue #2753