Fix build-tools/reaper source/target compatibility to be JDK-11 #2596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dblock please |
Rishikesh1159
approved these changes
Mar 25, 2022
|
❌ Gradle Check failure ce02a4980878154539bbf079867a31876055964e |
dblock
approved these changes
Mar 25, 2022
There was a problem hiding this comment.
- please audit all the JARs that we output and fix any others that are not source/target = 11
- open an issue to 1) find a way to inherit source/target compatibility from 1 place 2) find a systematic way to fail the build when some distribution JARs aren't the same version
|
@reta Thanks for jumping in. |
We have another outlier in |
|
❌ Gradle Check failure fe1d4f24d35aa7d82c5d78bdbea37006a559d10a |
|
❌ Gradle Check failure 34864f14ec00c86b805b9e3dbeebe21e84fced91 |
|
#1828 :( |
Signed-off-by: Andriy Redko <[email protected]>
dblock
added
backport 2.x
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Mar 25, 2022
Signed-off-by: Andriy Redko <[email protected]> (cherry picked from commit d4ce87b)
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Mar 25, 2022
Signed-off-by: Andriy Redko <[email protected]> (cherry picked from commit d4ce87b)
1 task
peterzhuamazon
pushed a commit
that referenced
this pull request
Mar 25, 2022
… (#2605) Signed-off-by: Andriy Redko <[email protected]> (cherry picked from commit d4ce87b) Co-authored-by: Andriy Redko <[email protected]>
peterzhuamazon
pushed a commit
that referenced
this pull request
Mar 25, 2022
… (#2606) Signed-off-by: Andriy Redko <[email protected]> (cherry picked from commit d4ce87b) Co-authored-by: Andriy Redko <[email protected]>
|
I am facing this issue when I am building 1.2 version. Should this be back ported to 1.x branches with 1.8 Java Version? |
@vamsi-amazon the 1.x has JDK 1.8 baseline, this change should not be backported |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Andriy Redko [email protected]
Description
Fix build-tools/reaper source/target compatibility to be JDK-11
Issues Resolved
Fixes #2581
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.