Add request parameter 'cluster_manager_timeout' as the alternative for 'master_timeout', and deprecate 'master_timeout' - in CAT APIs

[tlfeng]

Description

Apply the change of CAT Nodes API in PR #2435 to other applicable CAT APIs.

• Deprecate the request parameter master_timeout that used in many CAT APIs.
• Add alternative new request parameter cluster_manager_timeout.
• Add unit tests.

List of the CAT APIs that have got request parameter master_timeout:
CAT Allocation API https://opensearch.org/docs/opensearch/rest-api/cat/cat-allocation/
CAT Indices API https://opensearch.org/docs/opensearch/rest-api/cat/cat-indices/
CAT Master API https://opensearch.org/docs/opensearch/rest-api/cat/cat-master/
CAT Master API https://opensearch.org/docs/opensearch/rest-api/cat/cat-nodeattrs/
CAT Nodes API https://opensearch.org/docs/latest/opensearch/rest-api/cat/cat-nodes/
CAT Nodeattrs API https://opensearch.org/docs/opensearch/rest-api/cat/cat-nodes/
CAT Pending tasks API https://opensearch.org/docs/opensearch/rest-api/cat/cat-pending-tasks/
CAT Plugins API https://opensearch.org/docs/opensearch/rest-api/cat/cat-plugins/
CAT Repositories API https://opensearch.org/docs/opensearch/rest-api/cat/cat-repositories/
CAT Shards API https://opensearch.org/docs/opensearch/rest-api/cat/cat-shards/
CAT Snapshots API https://opensearch.org/docs/opensearch/rest-api/cat/cat-snapshots/
CAT Tamplates API https://opensearch.org/docs/opensearch/rest-api/cat/cat-templates/
CAT Thread pool API https://opensearch.org/docs/opensearch/rest-api/cat/cat-thread-pool/

Issues Resolved

A part of #2511

Check List

• New functionality includes testing.
  • All tests pass
• New functionality has been documented.
  • New functionality has javadoc added
• Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[opensearch-ci-bot]

✅   Gradle Check success 006da61
Log 3658

Reports 3658

[opensearch-ci-bot]

❌   Gradle Check failure fbec303
Log 3659

Reports 3659

[opensearch-ci-bot]

✅   Gradle Check success 7274938
Log 3660

Reports 3660

[opensearch-ci-bot]

❌   Gradle Check failure ef81890
Log 3835

Reports 3835

[opensearch-ci-bot]

❌   Gradle Check failure 365f0bd
Log 3836

Reports 3836

[tlfeng]

In log 3836:

REPRODUCE WITH: ./gradlew ':qa:remote-clusters:integTest' --tests "org.opensearch.cluster.remote.test.RemoteClustersIT.testHAProxyModeConnectionWorks" -Dtests.seed=5479B92A16DF1BD9 -Dtests.security.manager=true -Dtests.jvm.argline="-XX:TieredStopAtLevel=1 -XX:ReservedCodeCacheSize=64m" -Dtests.locale=tr -Dtests.timezone=Etc/UCT -Druntime.java=17
WARNING: A terminally deprecated method in java.lang.System has been called
WARNING: System::setSecurityManager has been called by org.gradle.api.internal.tasks.testing.worker.TestWorker (file:/home/ubuntu/.gradle/wrapper/dists/gradle-7.3.3-all/4295vidhdd9hd3gbjyw1xqxpo/gradle-7.3.3/lib/plugins/gradle-testing-base-7.3.3.jar)
WARNING: Please consider reporting this to the maintainers of org.gradle.api.internal.tasks.testing.worker.TestWorker
WARNING: System::setSecurityManager will be removed in a future release

org.opensearch.cluster.remote.test.RemoteClustersIT > testHAProxyModeConnectionWorks FAILED
    java.lang.AssertionError
        at __randomizedtesting.SeedInfo.seed([5479B92A16DF1BD9:530F6CE12D596D84]:0)
        at org.junit.Assert.fail(Assert.java:87)
        at org.junit.Assert.assertTrue(Assert.java:42)
        at org.junit.Assert.assertTrue(Assert.java:53)
        at org.opensearch.cluster.remote.test.RemoteClustersIT.testHAProxyModeConnectionWorks(RemoteClustersIT.java:125)

It's reported in issue #1703

[tlfeng]

Note: the massive change around these lines is only caused by the indentation change, which is made by variable name changed from masterNodeTimeout to clusterManagerNodeTimeout.

[opensearch-ci-bot]

✅   Gradle Check success 99e2b7b
Log 3863

Reports 3863

[opensearch-ci-bot]

✅   Gradle Check success e1a4be0
Log 3886

Reports 3886

[opensearch-ci-bot]

✅   Gradle Check success 80d99fd6ace86da3c8182889ad6d4d11fbe1ab0a
Log 3905

Reports 3905

[opensearch-ci-bot]

✅   Gradle Check success f97d74b
Log 3906

Reports 3906

[opensearch-ci-bot]

✅   Gradle Check success 4d0eb19a2184e87a8f8612dfe329c41229faca95
Log 4004

Reports 4004

[opensearch-ci-bot]

✅   Gradle Check success dc30f42
Log 4005

Reports 4005

[mch2]

LGTM