Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Remove] types from CreateIndexRequest and companion Builder's mapping method #2498

Merged
merged 2 commits into from
Mar 17, 2022
Merged

[Remove] types from CreateIndexRequest and companion Builder's mapping method #2498

merged 2 commits into from
Mar 17, 2022

Conversation

nknize
Copy link
Collaborator

@nknize nknize commented Mar 17, 2022

Removes the type variable as input to CreateIndexRequest.mapping(Object...)
along with the CreateIndexRequestBuilder helper class. This also refactors the
method name to setMapping for consistency with other methods (e.g.,
setSettings).

relates #1940

@nknize
[Remove] types from CIR and CIRB mapping method
6f1b02f 
Removes the type variable as input to CreateIndexRequest.mapping(Object...)
along with the CreateIndexRequestBuilder helper class. This also refactors the
method name to setMapping for consistency with other methods (e.g.,
setSettings).

Signed-off-by: Nicholas Walter Knize <[email protected]>
@nknize nknize added v2.0.0 Version 2.0.0 >breaking Identifies a breaking change. Indexing & Search labels Mar 17, 2022
@nknize nknize requested a review from a team as a code owner March 17, 2022 19:06
@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure 6f1b02f
Log 3497

Reports 3497

dreamer-89
dreamer-89 approved these changes Mar 17, 2022
View reviewed changes
Copy link
Member

@dreamer-89 dreamer-89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, LGTM!

@nknize
fix MetadataMappingServiceTests
f144716 
Signed-off-by: Nicholas Walter Knize <[email protected]>
dreamer-89
dreamer-89 approved these changes Mar 17, 2022
View reviewed changes
Copy link
Member

@dreamer-89 dreamer-89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure f144716
Log 3499

Reports 3499

@nknize nknize mentioned this pull request Mar 17, 2022
Closed
@nknize
Copy link
Collaborator Author

nknize commented Mar 17, 2022

Opened #2499 for non-reproducible failure:

REPRODUCE WITH: ./gradlew ':server:internalClusterTest' --tests "org.opensearch.versioning.ConcurrentSeqNoVersioningIT.testSeqNoCASLinearizability" -Dtests.seed=9A51991686B5895B -Dtests.security.manager=true -Dtests.jvm.argline="-XX:TieredStopAtLevel=1 -XX:ReservedCodeCacheSize=64m" -Dtests.locale=ar-IQ -Dtests.timezone=Pacific/Johnston -Druntime.java=17

org.opensearch.versioning.ConcurrentSeqNoVersioningIT > testSeqNoCASLinearizability FAILED
    MasterNotDiscoveredException[FailedToCommitClusterStateException[publication failed]; nested: OpenSearchException[publication cancelled before committing: timed out after 5s];]; nested: FailedToCommitClusterStateException[publication failed]; nested: OpenSearchException[publication cancelled before committing: timed out after 5s];
        at __randomizedtesting.SeedInfo.seed([9A51991686B5895B:419FB77C9CA7ABEF]:0)
        at org.opensearch.action.support.master.TransportMasterNodeAction$AsyncSingleAction$2.onTimeout(TransportMasterNodeAction.java:275)
        at org.opensearch.cluster.ClusterStateObserver$ContextPreservingListener.onTimeout(ClusterStateObserver.java:369)
        at org.opensearch.cluster.ClusterStateObserver$ObserverClusterStateListener.onTimeout(ClusterStateObserver.java:287)
        at org.opensearch.cluster.service.ClusterApplierService$NotifyTimeout.run(ClusterApplierService.java:692)
        at org.opensearch.common.util.concurrent.ThreadContext$ContextPreservingRunnable.run(ThreadContext.java:733)
        at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136)
        at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635)
        at java.lang.Thread.run(Thread.java:833)

refiring

@nknize
Copy link
Collaborator Author

nknize commented Mar 17, 2022

start gradle check

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Check success f144716
Log 3501

Reports 3501

@nknize nknize merged commit b9f0440 into opensearch-project:main Mar 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dreamer-89 dreamer-89 dreamer-89 approved these changes

@CEHENKLE CEHENKLE CEHENKLE approved these changes

@reta reta reta approved these changes

Assignees
No one assigned
Labels
>breaking Identifies a breaking change. Indexing & Search v2.0.0 Version 2.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nknize @opensearch-ci-bot @reta @CEHENKLE @dreamer-89