[Remove] Type from Percolate query API #2490
Conversation
| indexedDocumentType = in.readOptionalString(); | ||
| if (in.getVersion().before(Version.V_2_0_0)) { | ||
| String indexedDocumentType = in.readOptionalString(); | ||
| assert indexedDocumentType == null; |
There was a problem hiding this comment.
Is this assertion needed? readOptionalString assumes null value but not necessarily
There was a problem hiding this comment.
Thank you @reta for the comment. Typeless version of this query in 7.x is represented by a null documentType and indexedDocumentType.
There was a problem hiding this comment.
Instead of assert do we want to throw IllegalArgumentException since assertions could be disabled? (this is why we did it in other PRs so it would be consistent with those serialization methods)
There was a problem hiding this comment.
Thanks @nknize for the comment. I will replace assertion with throw IllegalArgumentException.
dreamer-89
force-pushed
the
remove-type-percolate-query
branch
from
0741191 to
4a7618a
Compare
|
✅ Gradle Check success 074119148fcde0afe467806f39559cf58870e148 |
|
✅ Gradle Check success 4a7618a95382fb8f4669a74eda372d41edaff633 |
Signed-off-by: Suraj Singh <[email protected]>
Signed-off-by: Suraj Singh <[email protected]>
dreamer-89
force-pushed
the
remove-type-percolate-query
branch
from
4a7618a to
d61b06a
Compare
dreamer-89
added
v2.0.0
Signed-off-by: Suraj Singh [email protected]
Description
Remove types from percolate query API
Related: #1940
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.