Adding shards per node constraint for predictability to testClusterGr… #2110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eenAfterPartialRelocation Signed-off-by: Ankit Jain <[email protected]>
|
Can one of the admins verify this patch? |
Signed-off-by: Ankit Jain <[email protected]>
|
start gradle check |
|
start gradle check |
dblock
approved these changes
Feb 15, 2022
server/src/test/java/org/opensearch/cluster/routing/MovePrimaryFirstTests.java
Outdated
Show resolved
Hide resolved
andrross
approved these changes
Feb 15, 2022
server/src/test/java/org/opensearch/cluster/routing/MovePrimaryFirstTests.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Ankit Jain <[email protected]>
|
start gradle check |
|
Unrelated error, restart gradle check |
|
start gradle check |
|
start gradle check |
|
start gradle check |
|
start gradle check |
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Feb 26, 2022
#2110) * Adding shards per node constraint for predictability to testClusterGreenAfterPartialRelocation Signed-off-by: Ankit Jain <[email protected]> * Fixing precommit violation Signed-off-by: Ankit Jain <[email protected]> * Adding assertion to ensure invariant Signed-off-by: Ankit Jain <[email protected]> (cherry picked from commit 8ae0db5)
andrross
pushed a commit
that referenced
this pull request
Feb 28, 2022
#2110) (#2265) * Adding shards per node constraint for predictability to testClusterGreenAfterPartialRelocation Signed-off-by: Ankit Jain <[email protected]> * Fixing precommit violation Signed-off-by: Ankit Jain <[email protected]> * Adding assertion to ensure invariant Signed-off-by: Ankit Jain <[email protected]> (cherry picked from commit 8ae0db5) Co-authored-by: Ankit Jain <[email protected]>
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…eenAfterPartialRelocation
Signed-off-by: Ankit Jain [email protected]
Description
The test was failing due to some replica shards initializing and completing before last primary shard could finish initializing. Added shards per node constraint to prevent this from happening. The test has become really lightweight, completes in less than 5 seconds mostly and ran locally without any failure more than 500 times
Issues Resolved
#1957
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.