Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added timeout to ensureGreen() for testClusterGreenAfterPartialReloca… #2074

Merged
merged 1 commit into from
Feb 9, 2022

Conversation

jainankitk
Copy link
Collaborator

…tion

Signed-off-by: Ankit Jain [email protected]

Description

The issue is caused due to one of the primary shard being initialized and some replica starts meanwhile. Hence, latch is counted down as half shards are already initialized. Making the check more robust by ensuring no primaries are initializing and not more than 20% of replicas have started on new nodes

Issues Resolved

#1957

Check List

  • New functionality includes testing.
    • All tests pass
  • [] New functionality has been documented.
    • [] New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@jainankitk jainankitk requested a review from a team as a code owner February 9, 2022 03:55
@opensearch-ci-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Check success 785ae2e
Log 2302

Reports 2302

Copy link
Member

@owaiskazi19 owaiskazi19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's try with 60 first and if it doesn't work we can change it to 120.

@owaiskazi19 owaiskazi19 merged commit f0984eb into opensearch-project:main Feb 9, 2022
@owaiskazi19 owaiskazi19 added pending backport Identifies an issue or PR that still needs to be backported v2.0.0 Version 2.0.0 backport 1.x labels Feb 9, 2022
@opensearch-trigger-bot
Copy link
Contributor

The backport to 1.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.x 1.x
# Navigate to the new working tree
cd .worktrees/backport-1.x
# Create a new branch
git switch --create backport/backport-2074-to-1.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 f0984eb409d44e8b68deb1c262bf81accc300acb
# Push it to GitHub
git push --set-upstream origin backport/backport-2074-to-1.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.x

Then, create a pull request where the base branch is 1.x and the compare/head branch is backport/backport-2074-to-1.x.

@VachaShah
Copy link
Collaborator

This PR cannot be backported to 1.x since the original change #1445 isn't in 1.x.

@jainankitk jainankitk deleted the fix-1957 branch February 9, 2022 22:14
@jainankitk
Copy link
Collaborator Author

This PR cannot be backported to 1.x since the original change #1445 isn't in 1.x.

Can we add backport 1.x label to #1445 ?

@VachaShah
Copy link
Collaborator

This PR cannot be backported to 1.x since the original change #1445 isn't in 1.x.

Can we add backport 1.x label to #1445 ?

Backport PR opened for #1445 - #2079

jainankitk added a commit to jainankitk/OpenSearch that referenced this pull request Feb 10, 2022
dblock pushed a commit that referenced this pull request Feb 11, 2022
* Stabilizing org.opensearch.cluster.routing.MovePrimaryFirstTests.test… (#2048)

* Stabilizing org.opensearch.cluster.routing.MovePrimaryFirstTests.testClusterGreenAfterPartialRelocation

Signed-off-by: Ankit Jain <[email protected]>

* Removing unused import

Signed-off-by: Ankit Jain <[email protected]>

* Making code more readable

Signed-off-by: Ankit Jain <[email protected]>
(cherry picked from commit 343b82f)

* Added timeout to ensureGreen() for testClusterGreenAfterPartialRelocation (#2074)

Signed-off-by: Ankit Jain <[email protected]>
(cherry picked from commit f0984eb)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 1.x pending backport Identifies an issue or PR that still needs to be backported v2.0.0 Version 2.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants