-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added timeout to ensureGreen() for testClusterGreenAfterPartialReloca… #2074
Conversation
…tion Signed-off-by: Ankit Jain <[email protected]>
Can one of the admins verify this patch? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's try with 60 first and if it doesn't work we can change it to 120.
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.x 1.x
# Navigate to the new working tree
cd .worktrees/backport-1.x
# Create a new branch
git switch --create backport/backport-2074-to-1.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 f0984eb409d44e8b68deb1c262bf81accc300acb
# Push it to GitHub
git push --set-upstream origin backport/backport-2074-to-1.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.x Then, create a pull request where the |
This PR cannot be backported to 1.x since the original change #1445 isn't in 1.x. |
…tion (opensearch-project#2074) Signed-off-by: Ankit Jain <[email protected]> (cherry picked from commit f0984eb)
* Stabilizing org.opensearch.cluster.routing.MovePrimaryFirstTests.test… (#2048) * Stabilizing org.opensearch.cluster.routing.MovePrimaryFirstTests.testClusterGreenAfterPartialRelocation Signed-off-by: Ankit Jain <[email protected]> * Removing unused import Signed-off-by: Ankit Jain <[email protected]> * Making code more readable Signed-off-by: Ankit Jain <[email protected]> (cherry picked from commit 343b82f) * Added timeout to ensureGreen() for testClusterGreenAfterPartialRelocation (#2074) Signed-off-by: Ankit Jain <[email protected]> (cherry picked from commit f0984eb)
…tion
Signed-off-by: Ankit Jain [email protected]
Description
The issue is caused due to one of the primary shard being initialized and some replica starts meanwhile. Hence, latch is counted down as half shards are already initialized. Making the check more robust by ensuring no primaries are initializing and not more than 20% of replicas have started on new nodes
Issues Resolved
#1957
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.