Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix AssertionError message #2044

Merged
merged 1 commit into from
Feb 2, 2022
Merged

Fix AssertionError message #2044

merged 1 commit into from
Feb 2, 2022

Conversation

lukas-vlcek
Copy link
Contributor

Description

The assertion error message was incorrectly requesting http protocol.

Issues Resolved

Too trivial to open a new ticket for.

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Lukáš Vlček [email protected]

@lukas-vlcek
Fix AssertionError message
c5c9ad5 
Signed-off-by: Lukáš Vlček <[email protected]>
@lukas-vlcek lukas-vlcek requested a review from a team as a code owner February 2, 2022 21:37
@opensearch-ci-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure c5c9ad5
Log 2195

Reports 2195

@andrross
Copy link
Member

andrross commented Feb 2, 2022

Another instance of #1957

org.opensearch.cluster.routing.MovePrimaryFirstTests > testClusterGreenAfterPartialRelocation FAILED
    java.lang.AssertionError: timed out waiting for green state
        at __randomizedtesting.SeedInfo.seed([BF26AB7586BF804F:ECECCF10ADFBFF5B]:0)
        at org.junit.Assert.fail(Assert.java:89)
        at org.opensearch.test.OpenSearchIntegTestCase.ensureColor(OpenSearchIntegTestCase.java:985)
        at org.opensearch.test.OpenSearchIntegTestCase.ensureGreen(OpenSearchIntegTestCase.java:924)
        at org.opensearch.test.OpenSearchIntegTestCase.ensureGreen(OpenSearchIntegTestCase.java:913)
        at org.opensearch.cluster.routing.MovePrimaryFirstTests.testClusterGreenAfterPartialRelocation(MovePrimaryFirstTests.java:68)

@andrross
Copy link
Member

andrross commented Feb 2, 2022

start gradle check

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Check success c5c9ad5
Log 2199

Reports 2199

@andrross andrross merged commit 270c59f into opensearch-project:main Feb 2, 2022
github-actions bot pushed a commit that referenced this pull request Feb 2, 2022
@lukas-vlcek @github-actions
Fix AssertionError message (#2044)
f6818d5 
Signed-off-by: Lukáš Vlček <[email protected]>
(cherry picked from commit 270c59f)
@github-actions github-actions bot mentioned this pull request Feb 2, 2022
Merged
dblock pushed a commit that referenced this pull request Feb 3, 2022
@github-actions @lukas-vlcek
Fix AssertionError message (#2044) (#2045)
bcdc193 
Signed-off-by: Lukáš Vlček <[email protected]>
(cherry picked from commit 270c59f)

Co-authored-by: Lukáš Vlček <[email protected]>
@lukas-vlcek lukas-vlcek deleted the fix_AssertionErrorMessage branch February 3, 2022 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrross andrross andrross approved these changes

Assignees
No one assigned
Labels
backport 1.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lukas-vlcek @opensearch-ci-bot @andrross