Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backport] [1.2] [plugin] repository-azure is not working properly hangs on basic operations #1745

Merged
merged 2 commits into from
Dec 16, 2021

Conversation

reta
Copy link
Collaborator

@reta reta commented Dec 16, 2021

Signed-off-by: Andriy Redko [email protected]

Description

Backport of #1740 to 1.2

Issues Resolved

Closes #1734

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@opensearch-ci-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Check success 87c1ec3
Log 1530

Reports 1530

@dblock
Copy link
Member

dblock commented Dec 16, 2021

Let’s wait on merging this to 1.2 for a short minute until 1.2.2 is released. I don’t think we want to hold a security patch for a feature regression.

@dblock
Copy link
Member

dblock commented Dec 16, 2021

Btw, if we can address #1707 we can significantly reduce the amount of work to do a 1.2.3 (no need to rebuild plugins at all). @nknize could use a comment from you on whether that’s by design or we can relax it.

@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure acb9eb81cab57026efe0f3e6c0172d8b8c42a5e8
Log 1534

Reports 1534

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Check success 16544b1
Log 1536

Reports 1536

@dblock dblock requested a review from andrross December 16, 2021 20:01
@dblock dblock merged commit 529b0cb into opensearch-project:1.2 Dec 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants