Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use the correct type to widen the sort fields when merging top docs #16881

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

bugmakerrrrrr
Copy link
Contributor

Description

See #16860

Related Issues

Resolves #16860

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Contributor

❌ Gradle check result for 219f48d: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Signed-off-by: panguixin <[email protected]>
Copy link
Contributor

✅ Gradle check result for c011176: SUCCESS

Copy link

codecov bot commented Dec 19, 2024

Codecov Report

Attention: Patch coverage is 70.96774% with 9 lines in your changes missing coverage. Please review.

Project coverage is 72.15%. Comparing base (b5f651f) to head (c011176).

Files with missing lines Patch % Lines
...pensearch/action/search/SearchPhaseController.java 66.66% 5 Missing and 4 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main   #16881      +/-   ##
============================================
- Coverage     72.21%   72.15%   -0.06%     
+ Complexity    65335    65315      -20     
============================================
  Files          5318     5318              
  Lines        304081   304098      +17     
  Branches      43995    44003       +8     
============================================
- Hits         219578   219416     -162     
- Misses        66541    66677     +136     
- Partials      17962    18005      +43     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Search Search query, autocomplete ...etc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use the correct type to widen the sort fields when merging top field docs
1 participant