Refactor Docker Compose version detection to predictably pick v2 only if v1 is not available #16793
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… if v1 is not available Signed-off-by: Andriy Redko <[email protected]>
reta
requested review from
anasalkouz,
andrross,
ashking94,
Bukhtawar,
CEHENKLE,
dblock,
dbwiddis,
gbbafna,
jainankitk,
kotwanikunal,
linuxpi,
mch2,
msfroh,
nknize,
owaiskazi19,
Rishikesh1159,
sachinpkale,
saratvemulapalli,
shwetathareja,
sohami and
VachaShah
as code owners
reta
commented
Dec 5, 2024
buildSrc/src/main/java/org/opensearch/gradle/docker/DockerSupportService.java
Show resolved
Hide resolved
cwperks
reviewed
Dec 5, 2024
buildSrc/src/main/java/org/opensearch/gradle/testfixtures/TestFixturesPlugin.java
Show resolved
Hide resolved
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #16793 +/- ##
============================================
+ Coverage 72.05% 72.11% +0.06%
- Complexity 65183 65206 +23
============================================
Files 5318 5318
Lines 303993 303996 +3
Branches 43990 43991 +1
============================================
+ Hits 219028 219213 +185
+ Misses 67046 66873 -173
+ Partials 17919 17910 -9 ☔ View full report in Codecov by Sentry. |
dblock
approved these changes
Dec 6, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Dec 6, 2024
… if v1 is not available (#16793) Signed-off-by: Andriy Redko <[email protected]> (cherry picked from commit 98dbc4a) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
reta
pushed a commit
that referenced
this pull request
Dec 6, 2024
… if v1 is not available (#16793) (#16800) (cherry picked from commit 98dbc4a) Signed-off-by: Andriy Redko <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactor Docker Compose version detection to predictably pick v2 only if v1 is not available. At the moment, if V1 and V2 are installed, the V1 is checked but ignored, with no option to be picked up.
Related Issues
Followup on #16049
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.