-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate performing update operation with default pipeline or final pipeline #16712
Conversation
…pipeline Signed-off-by: Gao Binlong <[email protected]>
❕ Gradle check result for 77c599c: UNSTABLE
Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #16712 +/- ##
============================================
+ Coverage 72.06% 72.14% +0.07%
- Complexity 65177 65213 +36
============================================
Files 5318 5318
Lines 303983 303988 +5
Branches 43986 43987 +1
============================================
+ Hits 219073 219304 +231
+ Misses 66964 66736 -228
- Partials 17946 17948 +2 ☔ View full report in Codecov by Sentry. |
server/src/main/java/org/opensearch/action/update/TransportUpdateAction.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Gao Binlong <[email protected]>
Signed-off-by: Gao Binlong <[email protected]>
Signed-off-by: Gao Binlong <[email protected]>
❕ Gradle check result for b5c1a07: UNSTABLE
Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
…pipeline (#16712) * Deprecate performing update operation with default pipeline or final pipeline Signed-off-by: Gao Binlong <[email protected]> * Modify the warning message Signed-off-by: Gao Binlong <[email protected]> * Modify changelog Signed-off-by: Gao Binlong <[email protected]> * Fix test issue Signed-off-by: Gao Binlong <[email protected]> --------- Signed-off-by: Gao Binlong <[email protected]> (cherry picked from commit d2a1477) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…eline or final pipeline (#16756) * Deprecate performing update operation with default pipeline or final pipeline (#16712) * Deprecate performing update operation with default pipeline or final pipeline Signed-off-by: Gao Binlong <[email protected]> * Modify the warning message Signed-off-by: Gao Binlong <[email protected]> * Modify changelog Signed-off-by: Gao Binlong <[email protected]> * Fix test issue Signed-off-by: Gao Binlong <[email protected]> --------- Signed-off-by: Gao Binlong <[email protected]> (cherry picked from commit d2a1477) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * Update 75_update.yml Signed-off-by: Andriy Redko <[email protected]> --------- Signed-off-by: Gao Binlong <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Signed-off-by: Andriy Redko <[email protected]> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Andriy Redko <[email protected]>
Description
Update API doesn't support ingest pipeline, but when there's a default pipeline or a final pipeline in the index and the specified document exists, the default pipeline or final pipeline will be executed, this behavior is unexpected and not consistent with the bulk API, we need to make the indexing result consistent in both APIs, so we need to change the behavior in Update API, we deprecate the support in Update API firstly and remove the support in 3.0.0 because it's a breaking change for some users.
Related Issues
#16663
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.