Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate performing update operation with default pipeline or final pipeline #16712

Merged
merged 5 commits into from
Dec 2, 2024

Conversation

gaobinlong
Copy link
Collaborator

@gaobinlong gaobinlong commented Nov 23, 2024

Description

Update API doesn't support ingest pipeline, but when there's a default pipeline or a final pipeline in the index and the specified document exists, the default pipeline or final pipeline will be executed, this behavior is unexpected and not consistent with the bulk API, we need to make the indexing result consistent in both APIs, so we need to change the behavior in Update API, we deprecate the support in Update API firstly and remove the support in 3.0.0 because it's a breaking change for some users.

Related Issues

#16663

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Contributor

❕ Gradle check result for 77c599c: UNSTABLE

  • TEST FAILURES:
      1 org.opensearch.cluster.MinimumClusterManagerNodesIT.testThreeNodesNoClusterManagerBlock

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Copy link

codecov bot commented Nov 23, 2024

Codecov Report

Attention: Patch coverage is 20.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 72.14%. Comparing base (b75f27a) to head (b5c1a07).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...pensearch/action/update/TransportUpdateAction.java 20.00% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main   #16712      +/-   ##
============================================
+ Coverage     72.06%   72.14%   +0.07%     
- Complexity    65177    65213      +36     
============================================
  Files          5318     5318              
  Lines        303983   303988       +5     
  Branches      43986    43987       +1     
============================================
+ Hits         219073   219304     +231     
+ Misses        66964    66736     -228     
- Partials      17946    17948       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Gao Binlong <[email protected]>
Copy link
Contributor

github-actions bot commented Dec 2, 2024

✅ Gradle check result for 859ed01: SUCCESS

Signed-off-by: Gao Binlong <[email protected]>
Signed-off-by: Gao Binlong <[email protected]>
Copy link
Contributor

github-actions bot commented Dec 2, 2024

❕ Gradle check result for b5c1a07: UNSTABLE

  • TEST FAILURES:
      1 org.opensearch.remotestore.RemoteStoreStatsIT.testDownloadStatsCorrectnessSinglePrimarySingleReplica
      1 org.opensearch.remotestore.RemoteStoreStatsIT.testDownloadStatsCorrectnessSinglePrimaryMultipleReplicaShards

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

@reta reta added v3.0.0 Issues and PRs related to version 3.0.0 ingest-pipeline v2.19.0 Issues and PRs related to version 2.19.0 labels Dec 2, 2024
@reta reta merged commit d2a1477 into opensearch-project:main Dec 2, 2024
50 of 51 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Dec 2, 2024
…pipeline (#16712)

* Deprecate performing update operation with default pipeline or final pipeline

Signed-off-by: Gao Binlong <[email protected]>

* Modify the warning message

Signed-off-by: Gao Binlong <[email protected]>

* Modify changelog

Signed-off-by: Gao Binlong <[email protected]>

* Fix test issue

Signed-off-by: Gao Binlong <[email protected]>

---------

Signed-off-by: Gao Binlong <[email protected]>
(cherry picked from commit d2a1477)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
reta added a commit that referenced this pull request Dec 2, 2024
…eline or final pipeline (#16756)

* Deprecate performing update operation with default pipeline or final pipeline (#16712)

* Deprecate performing update operation with default pipeline or final pipeline

Signed-off-by: Gao Binlong <[email protected]>

* Modify the warning message

Signed-off-by: Gao Binlong <[email protected]>

* Modify changelog

Signed-off-by: Gao Binlong <[email protected]>

* Fix test issue

Signed-off-by: Gao Binlong <[email protected]>

---------

Signed-off-by: Gao Binlong <[email protected]>
(cherry picked from commit d2a1477)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* Update 75_update.yml

Signed-off-by: Andriy Redko <[email protected]>

---------

Signed-off-by: Gao Binlong <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Signed-off-by: Andriy Redko <[email protected]>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Andriy Redko <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch ingest-pipeline v2.19.0 Issues and PRs related to version 2.19.0 v3.0.0 Issues and PRs related to version 3.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants