-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix stale cluster state custom file deletion #16670
Fix stale cluster state custom file deletion #16670
Conversation
server/src/main/java/org/opensearch/gateway/remote/RemoteClusterStateCleanupManager.java
Show resolved
Hide resolved
❌ Gradle check result for 15cc0a9: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
@soosinha lets add the changelog for the bug fix. |
❌ Gradle check result for 15cc0a9: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Sooraj Sinha <[email protected]>
15cc0a9
to
2e1bf62
Compare
@shwetathareja Added changelog |
❕ Gradle check result for 2e1bf62: UNSTABLE Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #16670 +/- ##
============================================
- Coverage 72.11% 72.09% -0.03%
- Complexity 65192 65214 +22
============================================
Files 5318 5318
Lines 303903 303908 +5
Branches 43970 43974 +4
============================================
- Hits 219166 219094 -72
- Misses 66786 66888 +102
+ Partials 17951 17926 -25 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
ac44300
into
opensearch-project:main
@soosinha Please raise a new PR for adding /update integ test ensuring delete works for every cluster state entity. |
Signed-off-by: Sooraj Sinha <[email protected]> (cherry picked from commit ac44300) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
(cherry picked from commit ac44300) Signed-off-by: Sooraj Sinha <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Description
When remote cluster state publication is enabled, cluster state custom objects get uploaded to remote store. The stale file deletion logic deletes stale remote state files. But the cluster state custom files are not getting deleted.
This PR fixes the logic for stale cluster state custom file deletion.
Related Issues
NA
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.