Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to support IP field in star tree indexing #16641

Merged
merged 3 commits into from
Dec 19, 2024

Conversation

bharath-techie
Copy link
Contributor

@bharath-techie bharath-techie commented Nov 14, 2024

Description

The changes include support for IP field as part of star tree index as part of dimensions specifically.

Related Issues

Resolves #16642

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions github-actions bot added enhancement Enhancement or improvement to existing feature or request Indexing:Performance labels Nov 14, 2024
Copy link
Contributor

❌ Gradle check result for 5ed38f0: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link

codecov bot commented Nov 14, 2024

Codecov Report

Attention: Patch coverage is 68.29268% with 13 lines in your changes missing coverage. Please review.

Project coverage is 72.14%. Comparing base (b5f651f) to head (bf12791).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...site/composite912/Composite912DocValuesWriter.java 36.36% 4 Missing and 3 partials ⚠️
...rch/index/compositeindex/datacube/IpDimension.java 73.68% 5 Missing ⚠️
...ndex/compositeindex/datacube/OrdinalDimension.java 66.66% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main   #16641      +/-   ##
============================================
- Coverage     72.21%   72.14%   -0.07%     
+ Complexity    65335    65276      -59     
============================================
  Files          5318     5319       +1     
  Lines        304081   304115      +34     
  Branches      43995    43999       +4     
============================================
- Hits         219578   219405     -173     
- Misses        66541    66679     +138     
- Partials      17962    18031      +69     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bharath-techie bharath-techie force-pushed the ipsupport branch 2 times, most recently from ab950b2 to 3edb512 Compare November 19, 2024 06:35
Copy link
Contributor

❌ Gradle check result for 3edb512: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for dbde796: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Signed-off-by: bharath-techie <[email protected]>
Copy link
Contributor

❌ Gradle check result for bc2e847: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Signed-off-by: bharath-techie <[email protected]>
Copy link
Contributor

❕ Gradle check result for 7a81d2f: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Copy link
Contributor

❕ Gradle check result for bf12791: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

@sachinpkale
Copy link
Member

Tests are added as part of integ tests as well. Codecov is failing as it does not include coverage from integ tests.

@sachinpkale sachinpkale merged commit e6d71d2 into opensearch-project:main Dec 19, 2024
38 of 39 checks passed
@sachinpkale sachinpkale added the backport 2.x Backport to 2.x branch label Dec 19, 2024
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-16641-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 e6d71d290e56e93920f8b8efa5ddbf885699607e
# Push it to GitHub
git push --set-upstream origin backport/backport-16641-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-16641-to-2.x.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch backport-failed enhancement Enhancement or improvement to existing feature or request Indexing:Performance skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] Support for IP fields as part of star tree index mapping
3 participants