Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Add a new configuration setting synonym_analyzer for synonym_graph and synonym #16625

Merged
merged 1 commit into from
Nov 13, 2024

Conversation

prudhvigodithi
Copy link
Member

@prudhvigodithi prudhvigodithi commented Nov 12, 2024

Description

Backport of #16488.

Related Issues

Part of #16263 and #16530.

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@prudhvigodithi prudhvigodithi force-pushed the 2.x branch 2 times, most recently from 95aa964 to c61313d Compare November 12, 2024 19:43
@prudhvigodithi prudhvigodithi marked this pull request as ready for review November 12, 2024 19:43
@prudhvigodithi prudhvigodithi changed the title [Backport 2.x] Add a new configuration setting synonym_analyzer for synonym_graph and synonym [Backport 2.x] Add a new configuration setting synonym_analyzer for synonym_graph and synonym Nov 12, 2024
Copy link
Contributor

❕ Gradle check result for c61313d: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Copy link

codecov bot commented Nov 12, 2024

Codecov Report

Attention: Patch coverage is 88.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 71.91%. Comparing base (94da76d) to head (406a0db).
Report is 8 commits behind head on 2.x.

Files with missing lines Patch % Lines
...rch/analysis/common/SynonymTokenFilterFactory.java 66.66% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                2.x   #16625      +/-   ##
============================================
+ Coverage     71.72%   71.91%   +0.19%     
- Complexity    65300    65481     +181     
============================================
  Files          5314     5314              
  Lines        305140   305187      +47     
  Branches      44458    44467       +9     
============================================
+ Hits         218859   219473     +614     
+ Misses        68025    67462     -563     
+ Partials      18256    18252       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

.idea/vcs.xml Outdated Show resolved Hide resolved
Copy link
Contributor

❕ Gradle check result for 406a0db: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants