-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support retrieving doc values of unsigned long field #16543
Conversation
Signed-off-by: panguixin <[email protected]>
Signed-off-by: panguixin <[email protected]>
@reta would you mind taking a look at this if you get a chance? |
Signed-off-by: panguixin <[email protected]>
server/src/test/java/org/opensearch/index/mapper/NumberFieldTypeTests.java
Outdated
Show resolved
Hide resolved
Signed-off-by: panguixin <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #16543 +/- ##
============================================
- Coverage 72.00% 72.00% -0.01%
+ Complexity 65038 65030 -8
============================================
Files 5313 5313
Lines 303454 303460 +6
Branches 43910 43910
============================================
- Hits 218510 218507 -3
- Misses 67040 67067 +27
+ Partials 17904 17886 -18 ☔ View full report in Codecov by Sentry. |
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-16543-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 a2a01f821760f7f27eaf6d30b6a4daaadda9fec8
# Push it to GitHub
git push --set-upstream origin backport/backport-16543-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.x Then, create a pull request where the |
ah @bugmakerrrrrr could you please backport to |
Changelog conflict. I think it just needed #16536 merged first. Will try toggling the backport label to see if it regenerates properly. |
* Support retrieving doc values of unsigned long field Signed-off-by: panguixin <[email protected]> * add test Signed-off-by: panguixin <[email protected]> * changelog Signed-off-by: panguixin <[email protected]> * randomize test Signed-off-by: panguixin <[email protected]> --------- Signed-off-by: panguixin <[email protected]> (cherry picked from commit a2a01f8) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* Support retrieving doc values of unsigned long field * add test * changelog * randomize test --------- (cherry picked from commit a2a01f8) Signed-off-by: panguixin <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Description
Implement the
LeafFieldData#getLeafValueFetcher
method for unsigned long field to support retrieving doc values. Previously, attempting to use thedocvalue_fields
parameter to access doc values would result in a UOE being thrown.Related Issues
Resolves #[Issue number to be closed when this PR is merged]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.