-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update DEVELOPER_GUIDE.md instructions for JDK-11 #16533
Update DEVELOPER_GUIDE.md instructions for JDK-11 #16533
Conversation
2719c16
to
2c4c285
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lots of things out of date here. Some file references are now stale (buildSrc/version.properties
). The comment about JDK 17 being the bundled JDK is wrong. Could we simplify this to say something to the effect of: "We recommend installing the latest LTS JDK and setting it as JAVA_HOME
. To run the full suite of bwc tests you must also install and configure JAVA11_HOME
and JAVA17_HOME
."
Update: I'm not sure JDK 11 is required, but it seems JDK 17 is.
Update 2: Both JDK 11 and 17 are required for the bwc tests.
It is, was focusing on immediate "need" but you are 100% right, going over the whole document |
07ede3d
to
5373441
Compare
Signed-off-by: Andriy Redko <[email protected]>
391c721
to
0e54adf
Compare
Signed-off-by: Andriy Redko <[email protected]>
Co-authored-by: Andrew Ross <[email protected]> Signed-off-by: Andriy Redko <[email protected]>
@andrross LGTY? thanks! |
Description
Update DEVELOPER_GUIDE.md instructions for JDK-11, fixes the annoying deprecation failure:
Related Issues
N/A (popped up in Slack from community member)
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.