-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Downgrade version to 2.18.0 for ser/de of new parameters of RequestRequest #16472
Downgrade version to 2.18.0 for ser/de of new parameters of RequestRequest #16472
Conversation
Signed-off-by: Spencer G. Jones <[email protected]>
❌ Gradle check result for 6a524f1: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #16472 +/- ##
=========================================
Coverage 72.06% 72.06%
- Complexity 65045 65089 +44
=========================================
Files 5313 5313
Lines 303382 303383 +1
Branches 43906 43906
=========================================
+ Hits 218633 218640 +7
+ Misses 66855 66853 -2
+ Partials 17894 17890 -4 ☔ View full report in Codecov by Sentry. |
@owaiskazi19 - this change should be back ported into 2.18 if possible, or at least into 2.19. |
Signed-off-by: Spencer G. Jones <[email protected]> (cherry picked from commit 936cdb9) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Added a backport label and the PR is created. @dbwiddis do we have to backport this to 2.18 branch as well? |
So no need to backport into 2.18, just putting in 2.x should work for future versions. |
Signed-off-by: Spencer G. Jones <[email protected]> (cherry picked from commit 936cdb9) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Although if we end up with a 2.18.1 it would need to be on 2.18 branch, so.... in that edge case, wouldn't hurt. |
Now that you've closed it...heh |
It'd probably be fine being 2.18.1 as current anyway, though. So I'd just leave things as is. |
I can open it again. 2.18 branch still has the TODO |
Based on the earlier backward compatibility failure, that could cause problems on a mixed cluster of 2.18.0 and 2.18.1 if this was not merged into 2.18. |
Signed-off-by: Spencer G. Jones <[email protected]> (cherry picked from commit 936cdb9) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
I was just thinking that about BWC during 2.18.0 to 2.18.1, so yeah, we should backport. |
…6475) (cherry picked from commit 936cdb9) Signed-off-by: Spencer G. Jones <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…6477) (cherry picked from commit 936cdb9) Signed-off-by: Spencer G. Jones <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Description
Downgrade version to 2.18.0 for serialization/deserialization of new parameters of RequestRequest added in PR #16292 since it has been back ported into that version.
Related Issues
Resolves #[Issue number to be closed when this PR is merged]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.