Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downgrade version to 2.18.0 for ser/de of new parameters of RequestRequest #16472

Conversation

mispencer
Copy link
Contributor

@mispencer mispencer commented Oct 24, 2024

Description

Downgrade version to 2.18.0 for serialization/deserialization of new parameters of RequestRequest added in PR #16292 since it has been back ported into that version.

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Contributor

❌ Gradle check result for 6a524f1: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

✅ Gradle check result for 6a524f1: SUCCESS

Copy link

codecov bot commented Oct 24, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 72.06%. Comparing base (9dd1a59) to head (6a524f1).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
...ster/snapshots/restore/RestoreSnapshotRequest.java 0.00% 0 Missing and 4 partials ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##               main   #16472   +/-   ##
=========================================
  Coverage     72.06%   72.06%           
- Complexity    65045    65089   +44     
=========================================
  Files          5313     5313           
  Lines        303382   303383    +1     
  Branches      43906    43906           
=========================================
+ Hits         218633   218640    +7     
+ Misses        66855    66853    -2     
+ Partials      17894    17890    -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@owaiskazi19 owaiskazi19 merged commit 936cdb9 into opensearch-project:main Oct 24, 2024
63 of 65 checks passed
@mispencer mispencer deleted the AliasRenameSnapshotRestoreVersionUpdate branch October 24, 2024 18:27
@mispencer
Copy link
Contributor Author

@owaiskazi19 - this change should be back ported into 2.18 if possible, or at least into 2.19.

@owaiskazi19 owaiskazi19 added the backport 2.x Backport to 2.x branch label Oct 24, 2024
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 24, 2024
Signed-off-by: Spencer G. Jones <[email protected]>
(cherry picked from commit 936cdb9)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@owaiskazi19
Copy link
Member

@owaiskazi19 - this change should be back ported into 2.18 if possible, or at least into 2.19.

Added a backport label and the PR is created. @dbwiddis do we have to backport this to 2.18 branch as well?

@dbwiddis
Copy link
Member

@owaiskazi19 - this change should be back ported into 2.18 if possible, or at least into 2.19.

Version.CURRENT in 2.18 is precisely Version.V_2_18_0.

public static final Version CURRENT = V_2_18_0;

So no need to backport into 2.18, just putting in 2.x should work for future versions.

opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 24, 2024
Signed-off-by: Spencer G. Jones <[email protected]>
(cherry picked from commit 936cdb9)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@dbwiddis
Copy link
Member

Although if we end up with a 2.18.1 it would need to be on 2.18 branch, so.... in that edge case, wouldn't hurt.

@dbwiddis
Copy link
Member

Now that you've closed it...heh

@dbwiddis
Copy link
Member

It'd probably be fine being 2.18.1 as current anyway, though. So I'd just leave things as is.

@owaiskazi19
Copy link
Member

I can open it again. 2.18 branch still has the TODO

@mispencer
Copy link
Contributor Author

Based on the earlier backward compatibility failure, that could cause problems on a mixed cluster of 2.18.0 and 2.18.1 if this was not merged into 2.18.

opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 24, 2024
Signed-off-by: Spencer G. Jones <[email protected]>
(cherry picked from commit 936cdb9)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@dbwiddis
Copy link
Member

I was just thinking that about BWC during 2.18.0 to 2.18.1, so yeah, we should backport.

owaiskazi19 pushed a commit that referenced this pull request Oct 24, 2024
…6475)

(cherry picked from commit 936cdb9)

Signed-off-by: Spencer G. Jones <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
dbwiddis pushed a commit that referenced this pull request Nov 7, 2024
…6477)

(cherry picked from commit 936cdb9)

Signed-off-by: Spencer G. Jones <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants