-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add paths to _cluster/stats API for metric filtering. #16425
base: main
Are you sure you want to change the base?
Add paths to _cluster/stats API for metric filtering. #16425
Conversation
Signed-off-by: Swetha Guptha <[email protected]>
❕ Gradle check result for e29169a: UNSTABLE Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #16425 +/- ##
============================================
- Coverage 72.05% 71.95% -0.11%
+ Complexity 64861 64789 -72
============================================
Files 5309 5309
Lines 302734 302785 +51
Branches 43733 43750 +17
============================================
- Hits 218134 217854 -280
- Misses 66731 67044 +313
- Partials 17869 17887 +18 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Does this need a documentation change?
Documentation change PR has been raised: opensearch-project/documentation-website#8595 |
@dbwiddis can you help in closing this review if there are no other concerns? |
Apologies for the delayed response.
Is this still required?
Being addressed in opensearch-project/opensearch-api-specification#639 |
The changelog verifier workflow is required to pass before it can be merged. In order for that to happen, either a changelog entry (for the appropriate version) must exist for the PR, or the While I could make assumptions here, my intent was to find out from you which of those options was the correct one to take, rather than guessing.
Thanks, would be great if you could edit the PR description where there's a checkbox for the API spec and link to it there... or just check the box like the one for documentation website is checked. I'm still a bit confused about whether (and if so, why) we are maintaining these specs in two different places ( |
This PR is stalled because it has been open for 30 days with no activity. |
Description
Add rest API specs for new URI paths added to _cluster/stats API for metric filtering in #15938.
Related Issues
Resolves #[Issue number to be closed when this PR is merged]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.