-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wlm create/update REST API bug fix #16422
Wlm create/update REST API bug fix #16422
Conversation
Signed-off-by: Kaushal Kumar <[email protected]>
Signed-off-by: Kaushal Kumar <[email protected]>
Signed-off-by: Kaushal Kumar <[email protected]>
Signed-off-by: Kaushal Kumar <[email protected]>
Signed-off-by: Kaushal Kumar <[email protected]>
❌ Gradle check result for fda8713: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Kaushal Kumar <[email protected]>
❌ Gradle check result for faed52c: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Ankit Jain <[email protected]>
❌ Gradle check result for bc784f0: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for bc784f0: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for ccb38cd: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for ccb38cd: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for ccb38cd: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Kaushal Kumar <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #16422 +/- ##
=========================================
Coverage 72.03% 72.03%
+ Complexity 64998 64972 -26
=========================================
Files 5313 5313
Lines 303293 303301 +8
Branches 43886 43886
=========================================
+ Hits 218476 218496 +20
+ Misses 66863 66825 -38
- Partials 17954 17980 +26 ☔ View full report in Codecov by Sentry. |
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-16422-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 760e67641a063adfec05721ef676e47d347b17a5
# Push it to GitHub
git push --set-upstream origin backport/backport-16422-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.x Then, create a pull request where the |
* test changes Signed-off-by: Kaushal Kumar <[email protected]> * fix the create/update queryGroup REST APIs Signed-off-by: Kaushal Kumar <[email protected]> * undo gradle change Signed-off-by: Kaushal Kumar <[email protected]> * add PR link in CHANGELOG Signed-off-by: Kaushal Kumar <[email protected]> * fix javadoc issues Signed-off-by: Kaushal Kumar <[email protected]> * remove redundant name param Signed-off-by: Kaushal Kumar <[email protected]> * Update CHANGELOG.md Signed-off-by: Ankit Jain <[email protected]> * fix action name in transport class for update query group Signed-off-by: Kaushal Kumar <[email protected]> --------- Signed-off-by: Kaushal Kumar <[email protected]> Signed-off-by: Ankit Jain <[email protected]> Co-authored-by: Ankit Jain <[email protected]>
* test changes * fix the create/update queryGroup REST APIs * undo gradle change * add PR link in CHANGELOG * fix javadoc issues * remove redundant name param * Update CHANGELOG.md * fix action name in transport class for update query group --------- Signed-off-by: Kaushal Kumar <[email protected]> Signed-off-by: Ankit Jain <[email protected]> Co-authored-by: Ankit Jain <[email protected]>
Description
WLM create/update REST APIs were not setup correctly since the APIs need to execute a clusterManager operation hence corresponding classes should extend
TransportClusterManagerNodeAction
class. This change is to fix it.previously when these two apis were resulting into an error like following when accessed using either cluster endpoint or non-cluster-manager node
After the fix it goes through and looks like following
Tested the changes in multi-node cluster setup.
Related Issues
Resolves #[Issue number to be closed when this PR is merged]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.