-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improve the rejection logic for wlm #16417
improve the rejection logic for wlm #16417
Conversation
Signed-off-by: Kaushal Kumar <[email protected]>
Signed-off-by: Kaushal Kumar <[email protected]>
f01d301
to
075fb23
Compare
❌ Gradle check result for 075fb23: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for 075fb23: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Unrelated failures:
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #16417 +/- ##
============================================
+ Coverage 72.03% 72.14% +0.11%
- Complexity 64998 65071 +73
============================================
Files 5313 5313
Lines 303293 303294 +1
Branches 43886 43888 +2
============================================
+ Hits 218476 218818 +342
+ Misses 66863 66545 -318
+ Partials 17954 17931 -23 ☔ View full report in Codecov by Sentry. |
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-16417-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 6891267608913dc27b21a65156ddd8817a8e9746
# Push it to GitHub
git push --set-upstream origin backport/backport-16417-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.x Then, create a pull request where the |
…ress (opensearch-project#16417) * improve the rejection logic for wlm Signed-off-by: Kaushal Kumar <[email protected]> * add CHANGELOG Signed-off-by: Kaushal Kumar <[email protected]> --------- Signed-off-by: Kaushal Kumar <[email protected]>
…ress (#16417) (#16438) * improve the rejection logic for wlm * add CHANGELOG --------- Signed-off-by: Kaushal Kumar <[email protected]>
Description
In workload management feature the rejection only works for
enforced
type of query groups. But rejection should work forsoft
type of query groups as well if the node is in duress. This change enhances the rejection mechanism in wlm.Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.