-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Backport 2.x] Fix typo super->sb in method toString() of RemoteStoreNodeAttribute(#15362) #16395
[Backport 2.x] Fix typo super->sb in method toString() of RemoteStoreNodeAttribute(#15362) #16395
Conversation
…pensearch-project#15362) * Removed unused StringBuilder Signed-off-by: Dmitry Kryukov <[email protected]> * Restored lines, fixed typo super -> sb Signed-off-by: Dmitry Kryukov <[email protected]> * Updated CHANGELOG.md Signed-off-by: Dmitry Kryukov <[email protected]> --------- Signed-off-by: Dmitry Kryukov <[email protected]>
a82663b
to
b99a0ac
Compare
❌ Gradle check result for b99a0ac: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 2.x #16395 +/- ##
============================================
- Coverage 71.91% 71.84% -0.07%
- Complexity 65221 65230 +9
============================================
Files 5308 5308
Lines 304350 304350
Branches 44268 44268
============================================
- Hits 218867 218661 -206
- Misses 67234 67561 +327
+ Partials 18249 18128 -121 ☔ View full report in Codecov by Sentry. |
Rebase? |
Most of my manual backports are adding to thte end of the changelog (that's why the conflicted again) and can be easily resolved by any maintainer clicking "Resolve Conflicts" and editing the changelog appropriately (after CI runs completely again, we shouldn't rerun CI based only on a changelog update!) |
Signed-off-by: Daniel Widdis <[email protected]>
@dblock could I get a re-review? The merge conflict resolution invalidated your previous one. 2.18 code freeze coming up today and I've got a few pending manual backports.... |
Backport 0419e5d from #15362