Revert #15258 to figure out a better approach to fix the issue. #16377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zane-neo
requested review from
anasalkouz,
andrross,
ashking94,
Bukhtawar,
CEHENKLE,
dblock,
dbwiddis,
gbbafna,
jainankitk,
kotwanikunal,
linuxpi,
mch2,
msfroh,
nknize,
owaiskazi19,
reta,
Rishikesh1159,
sachinpkale,
saratvemulapalli,
shwetathareja,
sohami and
VachaShah
as code owners
…x the issue. Signed-off-by: zane-neo <[email protected]>
zane-neo
force-pushed
the
revert-15258
branch
from
916c50c to
9ad7109
Compare
dbwiddis
approved these changes
Oct 18, 2024
|
Added skip-changelog tag since I don't think the workflow envisions reverting. :) |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #16377 +/- ##
============================================
+ Coverage 71.96% 71.98% +0.02%
- Complexity 64791 64820 +29
============================================
Files 5307 5307
Lines 302714 302718 +4
Branches 43733 43734 +1
============================================
+ Hits 217836 217925 +89
+ Misses 67013 66958 -55
+ Partials 17865 17835 -30 ☔ View full report in Codecov by Sentry. |
dk2k
pushed a commit
to dk2k/OpenSearch
that referenced
this pull request
Oct 21, 2024
…x the issue. (opensearch-project#16377) Signed-off-by: zane-neo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Revert #15258 to figure out a better approach to fix the issue.
Related Issues
#15258
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.