Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Snapshot V2] Do orphan timestamp cleanup before completing the snapshot #16365

Merged
merged 1 commit into from
Oct 18, 2024

Conversation

gbbafna
Copy link
Collaborator

@gbbafna gbbafna commented Oct 17, 2024

Description

Currently we do orphan timestamp clean up after sending ack to the client . In between leaving the repo loop and entering the loop again , if there is a snapshot , we delete the non-orphan time stamp as well . This is because the repositoryData which cleanOrphanTimestamp has becomes stale.

To simplify this, I intend to do cleanOrphanTimestamp when we are still in the repo loop which means that repositoryData will not change during this .

Check List

  • Functionality includes testing.
  • [ ] API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Contributor

❌ Gradle check result for 2386c93: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@gbbafna gbbafna changed the title Do orphan timestamp cleanup before completing the snapshot [Snapshot V2] Do orphan timestamp cleanup before completing the snapshot Oct 18, 2024
@gbbafna gbbafna marked this pull request as ready for review October 18, 2024 04:35
Copy link
Contributor

✅ Gradle check result for 2386c93: SUCCESS

Copy link

codecov bot commented Oct 18, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 72.07%. Comparing base (74dba3f) to head (c2ca7fe).
Report is 9 commits behind head on main.

Files with missing lines Patch % Lines
...ava/org/opensearch/snapshots/SnapshotsService.java 66.66% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main   #16365      +/-   ##
============================================
+ Coverage     71.89%   72.07%   +0.17%     
- Complexity    64750    64874     +124     
============================================
  Files          5307     5307              
  Lines        302664   302663       -1     
  Branches      43726    43723       -3     
============================================
+ Hits         217612   218154     +542     
+ Misses        67183    66645     -538     
+ Partials      17869    17864       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

❌ Gradle check result for c2ca7fe: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

✅ Gradle check result for c2ca7fe: SUCCESS

@sachinpkale sachinpkale merged commit f1c98a4 into opensearch-project:main Oct 18, 2024
37 of 38 checks passed
@sachinpkale sachinpkale added the backport 2.x Backport to 2.x branch label Oct 18, 2024
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 18, 2024
Signed-off-by: Gaurav Bafna <[email protected]>
(cherry picked from commit f1c98a4)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
dbwiddis pushed a commit that referenced this pull request Oct 19, 2024
…16385)

(cherry picked from commit f1c98a4)

Signed-off-by: Gaurav Bafna <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
sachinpkale added a commit to sachinpkale/OpenSearch that referenced this pull request Oct 20, 2024
sachinpkale added a commit to sachinpkale/OpenSearch that referenced this pull request Oct 20, 2024
dk2k pushed a commit to dk2k/OpenSearch that referenced this pull request Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants