-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skip media type parsing for known string values #16358
Skip media type parsing for known string values #16358
Conversation
Signed-off-by: Andrew Ross <[email protected]>
❌ Gradle check result for cae2f71: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any reason not to forward optimize and add the result of parseMediaType
to this map?
Love it @andrross ! Thank you!
@dblock I think it would complicate things a lot: I believe the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM to me!
@dblock I agree with @reta about the complexities. Also, in my simple testing I can't even find the |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #16358 +/- ##
============================================
+ Coverage 72.00% 72.03% +0.02%
- Complexity 64817 64838 +21
============================================
Files 5307 5307
Lines 302660 302670 +10
Branches 43724 43725 +1
============================================
+ Hits 217931 218022 +91
+ Misses 66906 66746 -160
- Partials 17823 17902 +79 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Andrew Ross <[email protected]> (cherry picked from commit e360ceb) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…6358) Signed-off-by: Andrew Ross <[email protected]>
(cherry picked from commit e360ceb) Signed-off-by: Andrew Ross <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…6358) Signed-off-by: Andrew Ross <[email protected]>
Less intrusive optimization solving the same problem as #16073
Related Issues
Resolves #15979
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.