Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed unneeded calls of String.format. #16357

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

dk2k
Copy link
Contributor

@dk2k dk2k commented Oct 16, 2024

Why do I think that they aren't needed?
No args provided for the string literal or there are no placeholders like %s in the string literal.

dk2k added 2 commits October 16, 2024 23:03
Signed-off-by: Dmitry Kryukov <[email protected]>
Copy link
Contributor

❌ Gradle check result for 9624556: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@dk2k dk2k marked this pull request as draft October 16, 2024 20:21
@sandeshkr419
Copy link
Contributor

Didn't notice this was still in draft. My bad.

Copy link
Member

@dbwiddis dbwiddis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM so far. Is it still in draft because you are adding more?

@opensearch-trigger-bot
Copy link
Contributor

This PR is stalled because it has been open for 30 days with no activity.

@opensearch-trigger-bot opensearch-trigger-bot bot added the stalled Issues that have stalled label Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stalled Issues that have stalled
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants