Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK-23: Mitigation for https://bugs.openjdk.org/browse/JDK-8341127 issue (performance regression) #16342

Merged
merged 1 commit into from
Oct 16, 2024

Conversation

reta
Copy link
Collaborator

@reta reta commented Oct 16, 2024

Description

JDK-23: Mitigation for https://bugs.openjdk.org/browse/JDK-8341127 issue (performance regression)

Related Issues

Part of #16255

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…sue (performance regression)

Signed-off-by: Andriy Redko <[email protected]>
@reta
Copy link
Collaborator Author

reta commented Oct 16, 2024

@rishabh6788 fyi

Copy link
Contributor

✅ Gradle check result for 4195120: SUCCESS

Copy link

codecov bot commented Oct 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.03%. Comparing base (35c366d) to head (4195120).
Report is 3 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #16342      +/-   ##
============================================
- Coverage     72.10%   72.03%   -0.08%     
+ Complexity    64862    64822      -40     
============================================
  Files          5307     5307              
  Lines        302606   302630      +24     
  Branches      43717    43720       +3     
============================================
- Hits         218208   217986     -222     
- Misses        66541    66745     +204     
- Partials      17857    17899      +42     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rishabh6788
Copy link
Contributor

Can we merge this PR?
The benchmark runtime for mainline has increased from 4-hr to 9-hr due to severe regression.

@jainankitk jainankitk merged commit d404359 into opensearch-project:main Oct 16, 2024
64 checks passed
dk2k pushed a commit to dk2k/OpenSearch that referenced this pull request Oct 16, 2024
dk2k pushed a commit to dk2k/OpenSearch that referenced this pull request Oct 17, 2024
dk2k pushed a commit to dk2k/OpenSearch that referenced this pull request Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants