-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimize flat_object type in a BWC way with one phase processing #16297
base: main
Are you sure you want to change the base?
Optimize flat_object type in a BWC way with one phase processing #16297
Conversation
Signed-off-by: panguixin <[email protected]>
7ca8d0b
to
5d37267
Compare
❌ Gradle check result for 5d37267: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: panguixin <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #16297 +/- ##
============================================
- Coverage 72.00% 71.97% -0.03%
+ Complexity 64796 64730 -66
============================================
Files 5307 5306 -1
Lines 302540 302356 -184
Branches 43708 43677 -31
============================================
- Hits 217853 217630 -223
- Misses 66801 66853 +52
+ Partials 17886 17873 -13 ☔ View full report in Codecov by Sentry. |
This PR is stalled because it has been open for 30 days with no activity. |
This PR is stalled because it has been open for 30 days with no activity. |
Description
As discussed in #16061, this PR focuses on optimizing
flat_object
type in a BWC way. I benchmarked this change using noaa workload and set the type of fieldstation
asflat_object
, the result is as follows.Related Issues
Resolves #[Issue number to be closed when this PR is merged]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.