Fix get index settings API doesn't show number_of_routing_shards when it was explicitly set on index creation #16294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… it was explicitly set on index creation Signed-off-by: Gao Binlong <[email protected]>
gaobinlong
requested review from
anasalkouz,
andrross,
ashking94,
Bukhtawar,
CEHENKLE,
dblock,
dbwiddis,
gbbafna,
jainankitk,
kotwanikunal,
linuxpi,
mch2,
msfroh,
nknize,
owaiskazi19,
reta,
Rishikesh1159,
sachinpkale,
saratvemulapalli,
shwetathareja,
sohami and
VachaShah
as code owners
|
@r1walz @Bukhtawar could you help to review this PR? Thanks! |
dbwiddis
previously approved these changes
Oct 12, 2024
|
❌ Gradle check result for 7eaef9c: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
dbwiddis
reviewed
Oct 12, 2024
...c/src/main/resources/rest-api-spec/test/indices.get_settings/40_number_of_routing_shards.yml
Show resolved
Hide resolved
Signed-off-by: Gao Binlong <[email protected]>
|
❌ Gradle check result for 0f6f4e5: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Gao Binlong <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #16294 +/- ##
============================================
- Coverage 72.03% 71.98% -0.05%
- Complexity 64782 64810 +28
============================================
Files 5307 5307
Lines 302545 302542 -3
Branches 43703 43703
============================================
- Hits 217925 217778 -147
- Misses 66712 66914 +202
+ Partials 17908 17850 -58 ☔ View full report in Codecov by Sentry. |
dbwiddis
approved these changes
Oct 12, 2024
Signed-off-by: Gao Binlong <[email protected]>
|
@reta, could you help to take a second look at this PR? Thanks! This change doesn't target for 2.18.0. |
reta
approved these changes
Oct 23, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 23, 2024
… it was explicitly set on index creation (#16294) * Fix get index settings API doesn't show number_of_routing_shards when it was explicitly set on index creation Signed-off-by: Gao Binlong <[email protected]> * Update skip version in rest yaml test file Signed-off-by: Gao Binlong <[email protected]> * Fix test failure Signed-off-by: Gao Binlong <[email protected]> --------- Signed-off-by: Gao Binlong <[email protected]> (cherry picked from commit 5941a7e) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
reta
added a commit
that referenced
this pull request
Oct 23, 2024
…ing_shards when it was explicitly set on index creation (#16453) * Fix get index settings API doesn't show number_of_routing_shards when it was explicitly set on index creation (#16294) * Fix get index settings API doesn't show number_of_routing_shards when it was explicitly set on index creation Signed-off-by: Gao Binlong <[email protected]> * Update skip version in rest yaml test file Signed-off-by: Gao Binlong <[email protected]> * Fix test failure Signed-off-by: Gao Binlong <[email protected]> --------- Signed-off-by: Gao Binlong <[email protected]> (cherry picked from commit 5941a7e) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * Update 40_number_of_routing_shards.yml Signed-off-by: Andriy Redko <[email protected]> --------- Signed-off-by: Gao Binlong <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Signed-off-by: Andriy Redko <[email protected]> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Andriy Redko <[email protected]>
|
I think this caused a YAML REST test in the python client to begin failing. I don't quite understand what those tests do, but what I know is that they fetch the YAML REST test list from |
3 tasks
Sure, I'll take a look, how do I check the test failure? Is there any logs? @dblock |
|
There's a failed job in https://github.com/opensearch-project/opensearch-py/actions/runs/11502167192/job/32016500189 |
|
@dblock The failure is caused by this line which assert that the key exists in the map, but the failed test case just tests that the key doesn't exists(if , so how about remove the assertion here and set value to None if the key doesn't exist?
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If the index level setting
index.number_of_routing_shardsis set explicitly at the index creation time, we don't show the setting in the response of get settings API, and we can only get the value byGET _cluster/state, this PR makes that setting shown in the response of the get settings API when it's explicitly set.Related Issues
#14199
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.