-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support prefix list for remote repository attributes #16271
Support prefix list for remote repository attributes #16271
Conversation
❌ Gradle check result for 5ff9010: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
5ff9010
to
338e30e
Compare
❌ Gradle check result for 338e30e: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for 7390f52: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
aeb9a11
to
f8b668c
Compare
❌ Gradle check result for f8b668c: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
f8b668c
to
bbc8d87
Compare
❌ Gradle check result for bbc8d87: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for 0792965: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
0792965
to
915ea10
Compare
❌ Gradle check result for 915ea10: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
915ea10
to
cf74258
Compare
❌ Gradle check result for cf74258: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
cf74258
to
a98a5de
Compare
❌ Gradle check result for a98a5de: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
20a98c6
to
c65085e
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #16271 +/- ##
============================================
- Coverage 72.15% 72.12% -0.03%
- Complexity 65145 65232 +87
============================================
Files 5315 5318 +3
Lines 303573 303890 +317
Branches 43925 43968 +43
============================================
+ Hits 219039 219177 +138
- Misses 66587 66778 +191
+ Partials 17947 17935 -12 ☔ View full report in Codecov by Sentry. |
server/src/main/java/org/opensearch/node/remotestore/RemoteStoreNodeAttribute.java
Show resolved
Hide resolved
c103127
to
d0cb67e
Compare
server/src/main/java/org/opensearch/node/remotestore/RemoteStoreNodeAttribute.java
Show resolved
Hide resolved
server/src/main/java/org/opensearch/node/remotestore/RemoteStoreNodeAttribute.java
Show resolved
Hide resolved
31ac8d1
to
1ce13fc
Compare
❌ Gradle check result for 1ce13fc: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
1ce13fc
to
2f95c0f
Compare
server/src/main/java/org/opensearch/node/remotestore/RemoteStoreNodeAttribute.java
Show resolved
Hide resolved
2f95c0f
to
615008f
Compare
❌ Gradle check result for 615008f: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
e92d3ce
to
8ed84e7
Compare
Signed-off-by: Rajiv Kumar Vaidyanathan <[email protected]>
Signed-off-by: Rajiv Kumar Vaidyanathan <[email protected]>
8ed84e7
to
a64284d
Compare
Signed-off-by: shwetathareja <[email protected]>
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-16271-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 548a6505d6eaa88170462ef5eaf45a89a367126e
# Push it to GitHub
git push --set-upstream origin backport/backport-16271-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.x Then, create a pull request where the |
…ect#16271) * Support prefix list for remote repository attributes Signed-off-by: Rajiv Kumar Vaidyanathan <[email protected]>
…ect#16271) * Support prefix list for remote repository attributes Signed-off-by: Rajiv Kumar Vaidyanathan <[email protected]>
* Support prefix list for remote repository attributes Signed-off-by: Rajiv Kumar Vaidyanathan <[email protected]>
Description
Introduce a new constant
remote_publication
in RemoteStoreAttribute and allow the remote repositories configured using the additional prefix. A node can be configured with either of the prefix attributesremote_store.<repository-type>.repository.*
(or)remote_publication.<repository-type>.repository.*
based on its type. This will allow in migrating a remote publication cluster from remote store to local.Related Issues
Resolves #[16390]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.