Revert remote publication method renaming in DiscoveryNode #16250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soosinha
requested review from
anasalkouz,
andrross,
ashking94,
Bukhtawar,
CEHENKLE,
dblock,
dbwiddis,
gbbafna,
jainankitk,
kotwanikunal,
linuxpi,
mch2,
msfroh,
nknize,
owaiskazi19,
reta,
Rishikesh1159,
sachinpkale,
saratvemulapalli,
shwetathareja,
sohami and
VachaShah
as code owners
|
❌ Gradle check result for b1047a6: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Sooraj Sinha <[email protected]>
soosinha
force-pushed
the
remote_pub_method
branch
from
b1047a6 to
d0b7d1a
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #16250 +/- ##
============================================
+ Coverage 71.97% 72.02% +0.04%
- Complexity 64771 64784 +13
============================================
Files 5302 5302
Lines 302473 302473
Branches 43699 43699
============================================
+ Hits 217715 217842 +127
+ Misses 66950 66772 -178
- Partials 17808 17859 +51 ☔ View full report in Codecov by Sentry. |
sandeshkr419
approved these changes
Oct 9, 2024
gbbafna
approved these changes
Oct 10, 2024
soosinha
added a commit
to soosinha/OpenSearch
that referenced
this pull request
Oct 10, 2024
…h-project#16250) Signed-off-by: Sooraj Sinha <[email protected]>
gbbafna
pushed a commit
that referenced
this pull request
Oct 10, 2024
…igured methods (#16249) * Separate Remote State and Publication enabled and configured methods (#16080) * Separate Remote State and Publication enabled and configured methods Signed-off-by: Shivansh Arora <[email protected]> * Revert remote publication method renaming in DiscoveryNode (#16250) Signed-off-by: Sooraj Sinha <[email protected]> --------- Signed-off-by: Shivansh Arora <[email protected]> Signed-off-by: Sooraj Sinha <[email protected]> Co-authored-by: Shivansh Arora <[email protected]>
This was referenced Oct 10, 2024
dk2k
pushed a commit
to dk2k/OpenSearch
that referenced
this pull request
Oct 16, 2024
…h-project#16250) Signed-off-by: Sooraj Sinha <[email protected]>
dk2k
pushed a commit
to dk2k/OpenSearch
that referenced
this pull request
Oct 17, 2024
…h-project#16250) Signed-off-by: Sooraj Sinha <[email protected]>
dk2k
pushed a commit
to dk2k/OpenSearch
that referenced
this pull request
Oct 21, 2024
…h-project#16250) Signed-off-by: Sooraj Sinha <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Reverting the name of method from
isRemoteStatePublicationConfiguredtoisRemoteStatePublicationEnabledsince DiscoveryNode is marked as PublicAPI and so the renaming of method would be a breaking change.The original change was pushed here : #16080
Related Issues
NA
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.